[Plone-UI] new content finder review
denys.mishunov at gmail.com
Mon Dec 3 21:25:46 UTC 2012
On Nov 29, 2012, at 11:54 AM, Denys Mishunov wrote:
> I think I would start with keyboard navigation as a pre-heat. search functionality would involve some more things. And even though I am responsible for the latest Plone search UI, I don't remember what the heck I was doing there :-P
I am done with the basic keyboard navigation for the widget (https://github.com/collective/plone-conf-2012-ui-sprint/pull/1). Could somebody review the pull request and merge it? Feedback on the missing/excess keys is welcome. Right now I have implemented just a tiny set for 98% of the cases I think.
The navigation 'into' a folder is not hocked up to any key yet, because we don't have any underlying code to handle this. I would like us to not concentrate on the styling now (because the styling is quite not optimal) but rather on functionality. Styling can be done in the same phase with getting rid of Chosen add-on.
I didn't do much cleaning except basic JSHint validation, trailing spaces etc. Working on it now on another branch (locally). I think we could optimize JS here quite dramatically and make the widget work faster. It's not a big deal now, but once we start implementing search capabilities in it, the slow speed of the widget will be noticeable I think.
http://mishunov.me • @mishunov
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the UI