[Testbot] Plone 4.3 - Python 2.6 - Build # 2625 - Still failing! - 0 failure(s)

jenkins at plone.org jenkins at plone.org
Tue Jan 20 17:29:11 UTC 2015


-------------------------------------------------------------------------------
Plone 4.3 - Python 2.6 - Build # 2625 - Still Failing!
-------------------------------------------------------------------------------

http://jenkins.plone.org/job/plone-4.3-python-2.6/2625/


-------------------------------------------------------------------------------
CHANGES
-------------------------------------------------------------------------------

Repository: Products.CMFPlone
Branch: refs/heads/4.3.x
Date: 2015-01-20T17:52:14+01:00
Author: Timo Stollenwerk () <contact at timostollenwerk.net>
Commit: https://github.com/plone/Products.CMFPlone/commit/9fae2ce6d7a02f2a8d948e96223764efd487848b

Comment out 'Log in form overlay closes on valid credentials' robot test. This test has been failing on Jenkins randomly for quite some time.

Files changed:
M Products/CMFPlone/tests/robot/test_overlays.robot

diff --git a/Products/CMFPlone/tests/robot/test_overlays.robot b/Products/CMFPlone/tests/robot/test_overlays.robot
index 4e3b763..4b92a65 100644
--- a/Products/CMFPlone/tests/robot/test_overlays.robot
+++ b/Products/CMFPlone/tests/robot/test_overlays.robot
@@ -44,10 +44,11 @@ Scenario: Log in form overlay remains on wrong credentials
      Then overlay should remain open
       And overlay shows an error
 
-Scenario: Log in form overlay closes on valid credentials
-    Given the 'Log in' overlay
-     When I enter valid credentials
-     Then overlay should close
+# XXX: This test fails randomly on Jenkins.
+#Scenario: Log in form overlay closes on valid credentials
+#    Given the 'Log in' overlay
+#     When I enter valid credentials
+#     Then overlay should close
 
 Scenario: Set default content item of a folder overlay opens
     Given a site owner


Repository: Products.CMFPlone
Branch: refs/heads/4.3.x
Date: 2015-01-20T17:52:30+01:00
Author: Timo Stollenwerk () <contact at timostollenwerk.net>
Commit: https://github.com/plone/Products.CMFPlone/commit/cfa8f3007ad8fa39e1dc8828d6c7e62d6ca86de8

Merge branch '4.3.x' of git://github.com/plone/Products.CMFPlone into 4.3.x

Files changed:
M Products/CMFPlone/browser/syndication/configure.zcml
M Products/CMFPlone/profiles/default/metadata.xml
M Products/CMFPlone/skins/plone_ecmascript/inline_validation.js
M Products/CMFPlone/skins/plone_ecmascript/kss-bbb.js
M Products/CMFPlone/skins/plone_ecmascript/select_all.js
M docs/CHANGES.rst
M setup.py

diff --git a/Products/CMFPlone/browser/syndication/configure.zcml b/Products/CMFPlone/browser/syndication/configure.zcml
index 424a7d4..9b6a82a 100644
--- a/Products/CMFPlone/browser/syndication/configure.zcml
+++ b/Products/CMFPlone/browser/syndication/configure.zcml
@@ -20,7 +20,7 @@
     for="Products.ATContentTypes.interfaces.topic.IATTopic"
     zcml:condition="installed Products.ATContentTypes" />
   <adapter factory=".adapters.SearchFeed"
-    for="Products.CMFPlone.interfaces.siteroot.IPloneSiteRoot"
+    for="plone.app.layout.navigation.interfaces.INavigationRoot"
     provides="Products.CMFPlone.interfaces.syndication.ISearchFeed" />
   <adapter factory=".adapters.DexterityItem"
     zcml:condition="installed plone.dexterity"
diff --git a/Products/CMFPlone/profiles/default/metadata.xml b/Products/CMFPlone/profiles/default/metadata.xml
index 662799c..03561d5 100644
--- a/Products/CMFPlone/profiles/default/metadata.xml
+++ b/Products/CMFPlone/profiles/default/metadata.xml
@@ -1,4 +1,4 @@
 <?xml version="1.0"?>
 <metadata>
-  <version>4309</version>
+  <version>4310</version>
 </metadata>
diff --git a/Products/CMFPlone/skins/plone_ecmascript/inline_validation.js b/Products/CMFPlone/skins/plone_ecmascript/inline_validation.js
index b59f148..029aa34 100644
--- a/Products/CMFPlone/skins/plone_ecmascript/inline_validation.js
+++ b/Products/CMFPlone/skins/plone_ecmascript/inline_validation.js
@@ -31,8 +31,18 @@ jQuery(function ($) {
             fname = $field.attr('data-fieldname'),
             value = $input.val();
 
+        // value is null for empty multiSelection select, turn it into a [] instead
+        // so it does not break at_validate_field
+        if ($input.attr('multiple') === 'multiple' && value === null) {
+            value = $([]).serialize();
+        }
+
+        // if value is an Array, it will be send as value[]=value1&value[]=value2 by $.post
+        // turn it into something that will be useable or value will be omitted from the request
+        params = $.param({uid: uid, fname: fname, value: value}, traditional = true);
+
         if ($field && uid && fname) {
-            $.post($('base').attr('href') + '/at_validate_field', {uid: uid, fname: fname, value: value}, function (data) {
+            $.post($('base').attr('href') + '/at_validate_field', params, function (data) {
                 render_error($field, data.errmsg);
             });
         }
diff --git a/Products/CMFPlone/skins/plone_ecmascript/kss-bbb.js b/Products/CMFPlone/skins/plone_ecmascript/kss-bbb.js
index 54e290f..1b4479d 100644
--- a/Products/CMFPlone/skins/plone_ecmascript/kss-bbb.js
+++ b/Products/CMFPlone/skins/plone_ecmascript/kss-bbb.js
@@ -80,7 +80,7 @@ $(document).ready(function(){
 
     /* sharing related kss */
     function updateSharing(data){
-        var sharing = $(data.body);
+        var sharing = data.body;
         var messages = $(data.messages).filter(function(){ return this.tagName == 'DL'; });
         $('.portalMessage').remove();
         $('#user-group-sharing').replaceWith(sharing);
diff --git a/Products/CMFPlone/skins/plone_ecmascript/select_all.js b/Products/CMFPlone/skins/plone_ecmascript/select_all.js
index dcd1fba..140600e 100644
--- a/Products/CMFPlone/skins/plone_ecmascript/select_all.js
+++ b/Products/CMFPlone/skins/plone_ecmascript/select_all.js
@@ -45,5 +45,5 @@ function toggleSelect(selectbutton, id, initialState, formName) {
     selectbutton.isSelected = !state;
     jQuery(selectbutton).attr('src', portal_url+'/select_'+(state?'all':'none')+'_icon.png');
     base = formName ? jQuery(document.forms[formName]) : jQuery(document);
-    base.find('input[name="' + fid + '"]:checkbox').attr('checked', !state);
+    base.find('input[name="' + fid + '"]:checkbox').prop('checked', !state);
 }
diff --git a/docs/CHANGES.rst b/docs/CHANGES.rst
index eae8bed..118c2fe 100644
--- a/docs/CHANGES.rst
+++ b/docs/CHANGES.rst
@@ -5,7 +5,28 @@
 Changelog
 =========
 
-4.3.4 (unreleased)
+4.3.5 (unreleased)
+------------------
+
+- Allow search_rss view on subsites (implementing INavigationRoot, not only
+  IPloneSiteRoot) like it was the case in Plone 4.1.6.
+  [vincentfretin]
+
+- jQuery 1.9 compatibility for the toggleSelect function (Select all checkbox)
+  [vincentfretin]
+
+- Sharing view javascript now works with jQuery 1.9.
+  [vincentfretin]
+
+
+4.3.4.1 (2014-11-13)
+--------------------
+
+- Make inline validation of AT multiple selection widget work.
+  [gbastien]
+
+
+4.3.4 (2014-10-22)
 ------------------
 
 - Fix getFolderContents to no longer ignore 'show_inactive' in contentFilter.
diff --git a/setup.py b/setup.py
index e97f62a..645d231 100644
--- a/setup.py
+++ b/setup.py
@@ -1,7 +1,7 @@
 from setuptools import setup, find_packages
 import os.path
 
-version = '4.3.4.dev0'
+version = '4.3.5.dev0'
 
 setup(name='Products.CMFPlone',
       version=version,




-------------------------------------------------------------------------------
-------------- next part --------------
A non-text attachment was scrubbed...
Name: CHANGES.log
Type: application/octet-stream
Size: 6860 bytes
Desc: not available
URL: <http://lists.plone.org/pipermail/plone-testbot/attachments/20150120/c3f303d3/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: build.log
Type: application/octet-stream
Size: 187591 bytes
Desc: not available
URL: <http://lists.plone.org/pipermail/plone-testbot/attachments/20150120/c3f303d3/attachment-0003.obj>


More information about the Testbot mailing list