[Testbot] Plone 4.3 - Python 2.6 - Build # 2616 - Regression! - 1 failure(s)

jenkins at plone.org jenkins at plone.org
Mon Jan 12 14:14:33 UTC 2015


-------------------------------------------------------------------------------
Plone 4.3 - Python 2.6 - Build # 2616 - Still Failing!
-------------------------------------------------------------------------------

http://jenkins.plone.org/job/plone-4.3-python-2.6/2616/


-------------------------------------------------------------------------------
CHANGES
-------------------------------------------------------------------------------

Repository: Products.CMFPlone
Branch: refs/heads/4.3.x
Date: 2015-01-12T14:37:26+01:00
Author: Vincent Fretin (vincentfretin) <vincent.fretin at gmail.com>
Commit: https://github.com/plone/Products.CMFPlone/commit/07343604f4523109bb6c7262ce4191af47e741f8

jQuery 1.9 compatibility for the toggleSelect function (Select all checkbox)

Files changed:
M Products/CMFPlone/skins/plone_ecmascript/select_all.js
M docs/CHANGES.rst

diff --git a/Products/CMFPlone/skins/plone_ecmascript/select_all.js b/Products/CMFPlone/skins/plone_ecmascript/select_all.js
index dcd1fba..140600e 100644
--- a/Products/CMFPlone/skins/plone_ecmascript/select_all.js
+++ b/Products/CMFPlone/skins/plone_ecmascript/select_all.js
@@ -45,5 +45,5 @@ function toggleSelect(selectbutton, id, initialState, formName) {
     selectbutton.isSelected = !state;
     jQuery(selectbutton).attr('src', portal_url+'/select_'+(state?'all':'none')+'_icon.png');
     base = formName ? jQuery(document.forms[formName]) : jQuery(document);
-    base.find('input[name="' + fid + '"]:checkbox').attr('checked', !state);
+    base.find('input[name="' + fid + '"]:checkbox').prop('checked', !state);
 }
diff --git a/docs/CHANGES.rst b/docs/CHANGES.rst
index 87392a2..0abca5f 100644
--- a/docs/CHANGES.rst
+++ b/docs/CHANGES.rst
@@ -8,6 +8,9 @@ Changelog
 4.3.5 (unreleased)
 ------------------
 
+- jQuery 1.9 compatibility for the toggleSelect function (Select all checkbox)
+  [vincentfretin]
+
 - Sharing view javascript now works with jQuery 1.9.
   [vincentfretin]
 




-------------------------------------------------------------------------------
-------------- next part --------------
A non-text attachment was scrubbed...
Name: CHANGES.log
Type: application/octet-stream
Size: 1524 bytes
Desc: not available
URL: <http://lists.plone.org/pipermail/plone-testbot/attachments/20150112/50d420c2/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: build.log
Type: application/octet-stream
Size: 188376 bytes
Desc: not available
URL: <http://lists.plone.org/pipermail/plone-testbot/attachments/20150112/50d420c2/attachment-0003.obj>


More information about the Testbot mailing list