[Testbot] Plone 4.3 - Python 2.7 - Build # 2571 - Fixed! - 0 failure(s)

jenkins at plone.org jenkins at plone.org
Tue Sep 23 00:14:55 UTC 2014


-------------------------------------------------------------------------------
Plone 4.3 - Python 2.7 - Build # 2571 - Fixed!
-------------------------------------------------------------------------------

http://jenkins.plone.org/job/plone-4.3-python-2.7/2571/


-------------------------------------------------------------------------------
CHANGES
-------------------------------------------------------------------------------

Repository: plone.app.dexterity
Branch: refs/heads/master
Date: 2014-04-24T17:52:05+02:00
Author: Victor Fernandez de Alba (sneridagh) <sneridagh at gmail.com>
Commit: https://github.com/plone/plone.app.dexterity/commit/c1b987764afe0155c7672a570b72483d9bb0daef

Get rid of all dl/dd when displaying alerts from templates.

Files changed:
M plone/app/dexterity/browser/default_page_warning.pt
M plone/app/dexterity/browser/types_listing.pt

diff --git a/plone/app/dexterity/browser/default_page_warning.pt b/plone/app/dexterity/browser/default_page_warning.pt
index f3e32de..c0818d0 100644
--- a/plone/app/dexterity/browser/default_page_warning.pt
+++ b/plone/app/dexterity/browser/default_page_warning.pt
@@ -1,13 +1,14 @@
-<dl class="portalMessage info"
+<div class="portalMessage info" role="alertdialog" aria-labelledby="dialogTitle"
     tal:condition="context/@@plone_context_state/is_default_page|nothing">
-    <dt i18n:translate="">
+    <strong id="dialogTitle"
+            i18n:translate="">
         Info
-    </dt>
-    <dd i18n:translate="label_edit_default_view_container">
+    </strong>
+    <span i18n:translate="label_edit_default_view_container">
         You are editing the default view of a container. If you wanted to edit the container itself,
        <a href=""
           i18n:name="go_here"
           i18n:translate="label_edit_default_view_container_go_here"
           tal:attributes="href string:${context/aq_inner/aq_parent/absolute_url}/edit">go here</a>.
-    </dd>
-</dl>
+    </span>
+</div>
diff --git a/plone/app/dexterity/browser/types_listing.pt b/plone/app/dexterity/browser/types_listing.pt
index 91d1986..0ff523f 100644
--- a/plone/app/dexterity/browser/types_listing.pt
+++ b/plone/app/dexterity/browser/types_listing.pt
@@ -4,11 +4,16 @@
 <script type="text/javascript"
         tal:attributes="src context/++resource++plone.app.dexterity.types_listing.js"></script>
 
-<dl class="portalMessage"
+<div class="portalMessage" role="alertdialog" aria-labelledby="dialogTitle"
      tal:condition="view/status">
-  <dt>Info</dt>
-  <dd tal:content="view/status"/>
-</dl>
+  <strong id="dialogTitle"
+          i18n:translate="">
+    Info
+  </strong>
+  <span tal:content="view/status">
+    Status
+  </span>
+</div>
 
 <p class="crud-description"
      tal:condition="view/description"


Repository: plone.app.dexterity
Branch: refs/heads/master
Date: 2014-09-23T01:21:54+02:00
Author: Jens W. Klein (jensens) <jk at kleinundpartner.at>
Commit: https://github.com/plone/plone.app.dexterity/commit/bcbfb5add0d0437f614a9fba139a8f0cfcff2d65

Merge pull request #120 from plone/sneridagh-plog2014

Get rid of all dl/dd when displaying alerts from templates.

Files changed:
M plone/app/dexterity/browser/default_page_warning.pt
M plone/app/dexterity/browser/types_listing.pt

diff --git a/plone/app/dexterity/browser/default_page_warning.pt b/plone/app/dexterity/browser/default_page_warning.pt
index f3e32de..c0818d0 100644
--- a/plone/app/dexterity/browser/default_page_warning.pt
+++ b/plone/app/dexterity/browser/default_page_warning.pt
@@ -1,13 +1,14 @@
-<dl class="portalMessage info"
+<div class="portalMessage info" role="alertdialog" aria-labelledby="dialogTitle"
     tal:condition="context/@@plone_context_state/is_default_page|nothing">
-    <dt i18n:translate="">
+    <strong id="dialogTitle"
+            i18n:translate="">
         Info
-    </dt>
-    <dd i18n:translate="label_edit_default_view_container">
+    </strong>
+    <span i18n:translate="label_edit_default_view_container">
         You are editing the default view of a container. If you wanted to edit the container itself,
        <a href=""
           i18n:name="go_here"
           i18n:translate="label_edit_default_view_container_go_here"
           tal:attributes="href string:${context/aq_inner/aq_parent/absolute_url}/edit">go here</a>.
-    </dd>
-</dl>
+    </span>
+</div>
diff --git a/plone/app/dexterity/browser/types_listing.pt b/plone/app/dexterity/browser/types_listing.pt
index 91d1986..0ff523f 100644
--- a/plone/app/dexterity/browser/types_listing.pt
+++ b/plone/app/dexterity/browser/types_listing.pt
@@ -4,11 +4,16 @@
 <script type="text/javascript"
         tal:attributes="src context/++resource++plone.app.dexterity.types_listing.js"></script>
 
-<dl class="portalMessage"
+<div class="portalMessage" role="alertdialog" aria-labelledby="dialogTitle"
      tal:condition="view/status">
-  <dt>Info</dt>
-  <dd tal:content="view/status"/>
-</dl>
+  <strong id="dialogTitle"
+          i18n:translate="">
+    Info
+  </strong>
+  <span tal:content="view/status">
+    Status
+  </span>
+</div>
 
 <p class="crud-description"
      tal:condition="view/description"




-------------------------------------------------------------------------------


More information about the Testbot mailing list