[Testbot] Plone 4.3 - Python 2.6 - Build # 2426 - Improvement! - 1 failure(s)

jenkins at plone.org jenkins at plone.org
Tue Oct 14 11:28:13 UTC 2014


-------------------------------------------------------------------------------
Plone 4.3 - Python 2.6 - Build # 2426 - Still Failing!
-------------------------------------------------------------------------------

http://jenkins.plone.org/job/plone-4.3-python-2.6/2426/


-------------------------------------------------------------------------------
CHANGES
-------------------------------------------------------------------------------

Repository: plone.app.layout
Branch: refs/heads/2.3.x
Date: 2014-10-14T12:36:56+02:00
Author: Jens W. Klein (jensens) <jk at kleinundpartner.at>
Commit: https://github.com/plone/plone.app.layout/commit/3a9e1ff532b0fa960c0608fe49e8efb5d3ac79d0

 in test passing portal to addMember, not testcase class

Files changed:
M CHANGES.rst
M plone/app/layout/viewlets/tests/test_content.py

diff --git a/CHANGES.rst b/CHANGES.rst
index 8f7a3de..72613b0 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -4,7 +4,8 @@ Changelog
 2.3.13 (unreleased)
 -------------------
 
-- Nothing changed yet.
+- Fix: in test passing portal to addMember, not testcase class.
+  [jensens]
 
 
 2.3.12 (2014-09-07)
diff --git a/plone/app/layout/viewlets/tests/test_content.py b/plone/app/layout/viewlets/tests/test_content.py
index 6c7045b..3bf71bc 100644
--- a/plone/app/layout/viewlets/tests/test_content.py
+++ b/plone/app/layout/viewlets/tests/test_content.py
@@ -32,8 +32,8 @@ class TestDocumentBylineViewletView(ViewletsTestCase):
     Test the document by line viewlet
     """
     def afterSetUp(self):
-        addMember(self, 'Alan', roles=('Member', 'Manager'))
-        addMember(self, 'Ano', roles=())
+        addMember(self.portal, 'Alan', roles=('Member', 'Manager'))
+        addMember(self.portal, 'Ano', roles=())
 
     def test_anonymous_locked_icon(self):
         request = self.app.REQUEST
@@ -60,13 +60,13 @@ def test_locked_icon(self):
         lockIconUrl = '<img src="http://nohost/plone/lock_icon.png" alt="" \
 title="Locked" height="16" width="16" />'
         self.assertEqual(viewlet.locked_icon(), lockIconUrl)
-    
+
     def test_pub_date(self):
         request = self.app.REQUEST
         self.login('Alan')
         self.portal.invokeFactory('Document', 'd1')
         context = getattr(self.portal, 'd1')
-        
+
         # configure our portal to enable publication date on pages globally on
         # the site
         properties = getToolByName(context, 'portal_properties')
@@ -76,7 +76,7 @@ def test_pub_date(self):
         self.login('Ano')
         viewlet = DocumentBylineViewlet(context, request, None, None)
         viewlet.update()
-        
+
         # publication date should be None as there is not Effective date set for
         # our document yet
         self.assertEqual(viewlet.pub_date(), None)
@@ -85,7 +85,7 @@ def test_pub_date(self):
         effective = DateTime()
         context.setEffectiveDate(effective)
         self.assertEqual(viewlet.pub_date(), DateTime(effective.ISO8601()))
-        
+
         # now switch off publication date globally on the site and see if
         # viewlet returns None for publication date
         site_properties.displayPublicationDateInByline = False




-------------------------------------------------------------------------------
-------------- next part --------------
A non-text attachment was scrubbed...
Name: CHANGES.log
Type: application/octet-stream
Size: 2735 bytes
Desc: not available
URL: <http://lists.plone.org/pipermail/plone-testbot/attachments/20141014/e66ab103/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: build.log
Type: application/octet-stream
Size: 172290 bytes
Desc: not available
URL: <http://lists.plone.org/pipermail/plone-testbot/attachments/20141014/e66ab103/attachment-0003.obj>


More information about the Testbot mailing list