[Testbot] Plone 5.0 - Python 2.7 - Build # 3298 - Still failing! - 0 failure(s)
jenkins at plone.org
jenkins at plone.org
Wed Oct 8 13:28:15 UTC 2014
-------------------------------------------------------------------------------
Plone 5.0 - Python 2.7 - Build # 3298 - Still Failing!
-------------------------------------------------------------------------------
http://jenkins.plone.org/job/plone-5.0-python-2.7/3298/
-------------------------------------------------------------------------------
CHANGES
-------------------------------------------------------------------------------
Repository: plone.formwidget.namedfile
Branch: refs/heads/master
Date: 2014-10-08T15:57:22+03:00
Author: Roman Kozlovskyi (kroman0) <kroman0 at users.noreply.github.com>
Commit: https://github.com/plone/plone.formwidget.namedfile/commit/9442a362cefd37bdc950e582c5bbc94f61ca8ede
Fixed tests
Fixed tests after fixing inserting filename in to Content-Disposition header in https://github.com/plone/plone.namedfile/commit/8e0c90c31a7d2b9c54112865d9a9ff78e168891e
Files changed:
M plone/formwidget/namedfile/widget.txt
diff --git a/plone/formwidget/namedfile/widget.txt b/plone/formwidget/namedfile/widget.txt
index e555554..3a24320 100644
--- a/plone/formwidget/namedfile/widget.txt
+++ b/plone/formwidget/namedfile/widget.txt
@@ -439,14 +439,14 @@ this view to display the image itself or link to the file.
>>> view()
'My image data'
>>> request.response.getHeader('Content-Disposition')
- 'attachment; filename="faux.png"'
+ "attachment; filename*=UTF-8''faux.png"
>>> request = TestRequest()
>>> view = Download(file_widget, request)
>>> view()
'My file data'
>>> request.response.getHeader('Content-Disposition')
- 'attachment; filename="data.txt"'
+ "attachment; filename*=UTF-8''data.txt"
The URL will influence the name of the file as reported to the browser, but
doesn't stop it being found.
@@ -457,7 +457,7 @@ doesn't stop it being found.
>>> view()
'My file data'
>>> request.response.getHeader('Content-Disposition')
- 'attachment; filename="daisy.txt"'
+ "attachment; filename*=UTF-8''daisy.txt"
Any additional traversal will result in an error.
-------------------------------------------------------------------------------
-------------- next part --------------
A non-text attachment was scrubbed...
Name: CHANGES.log
Type: application/octet-stream
Size: 1608 bytes
Desc: not available
URL: <http://lists.plone.org/pipermail/plone-testbot/attachments/20141008/fc333ce9/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: build.log
Type: application/octet-stream
Size: 94234 bytes
Desc: not available
URL: <http://lists.plone.org/pipermail/plone-testbot/attachments/20141008/fc333ce9/attachment-0003.obj>
More information about the Testbot
mailing list