[Testbot] Plone 4.3 - Python 2.7 - Build # 2281 - Regression! - 1 failure(s)

[jenkins at plone.org]

-------------------------------------------------------------------------------
Plone 4.3 - Python 2.7 - Build # 2281 - Failure!
-------------------------------------------------------------------------------

http://jenkins.plone.org/job/plone-4.3-python-2.7/2281/


-------------------------------------------------------------------------------
CHANGES
-------------------------------------------------------------------------------

Repository: plone.app.contenttypes
Branch: refs/heads/master
Date: 2014-05-22T11:40:11+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits at vanrees.org>
Commit: https://github.com/plone/plone.app.contenttypes/commit/f2b25730ede6a45db635c405c0147db6bc0bf69f

Reverse the sort order correctly when replacing default collections.

This is for the default news and events collections.

Previously we set `reverse_sort` to True, but it should have been `sort_reversed`.

Files changed:
M docs/CHANGES.rst
M plone/app/contenttypes/setuphandlers.py
M plone/app/contenttypes/tests/test_content_profile.py

diff --git a/docs/CHANGES.rst b/docs/CHANGES.rst
index 74910ed..2a2fa12 100644
--- a/docs/CHANGES.rst
+++ b/docs/CHANGES.rst
@@ -4,7 +4,9 @@ Changelog
 1.2a4 (unreleased)
 ------------------
 
-- Nothing changed yet.
+- When replacing the default news and events collections, reverse the
+  sort order correctly.
+  [maurits]
 
 
 1.2a3 (2014-04-19)
diff --git a/plone/app/contenttypes/setuphandlers.py b/plone/app/contenttypes/setuphandlers.py
index f695a9b..a780f13 100644
--- a/plone/app/contenttypes/setuphandlers.py
+++ b/plone/app/contenttypes/setuphandlers.py
@@ -246,7 +246,7 @@ def create_news_topic(portal, target_language):
         # Set the Collection criteria.
         #: Sort on the Effective date
         aggregator.sort_on = u'effective'
-        aggregator.reverse_sort = True
+        aggregator.sort_reversed = True
         #: Query by Type and Review State
         aggregator.query = [
             {'i': u'portal_type',
@@ -291,7 +291,7 @@ def create_events_topic(portal, target_language):
         # Set the Collection criteria.
         #: Sort on the Event start date
         aggregator.sort_on = u'start'
-        aggregator.reverse_sort = True
+        aggregator.sort_reversed = True
         #: Query by Type, Review State and Event start date after today
         aggregator.query = [
             {'i': 'portal_type',
diff --git a/plone/app/contenttypes/tests/test_content_profile.py b/plone/app/contenttypes/tests/test_content_profile.py
index 92e2dff..5c40408 100644
--- a/plone/app/contenttypes/tests/test_content_profile.py
+++ b/plone/app/contenttypes/tests/test_content_profile.py
@@ -182,6 +182,6 @@ def test_news_aggregator_settings(self):
                  ]
         collection = self.portal['news']['aggregator']
         self.assertEqual(collection.sort_on, u'effective')
-        self.assertEqual(collection.reverse_sort, True)
+        self.assertEqual(collection.sort_reversed, True)
         self.assertItemsEqual(collection.query, query)
         self.assertEqual(collection.getLayout(), 'summary_view')




-------------------------------------------------------------------------------
-------------- next part --------------
A non-text attachment was scrubbed...
Name: CHANGES.log
Type: application/octet-stream
Size: 2661 bytes
Desc: not available
URL: <http://lists.plone.org/pipermail/plone-testbot/attachments/20140522/fa5ed8a7/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: build.log
Type: application/octet-stream
Size: 82098 bytes
Desc: not available
URL: <http://lists.plone.org/pipermail/plone-testbot/attachments/20140522/fa5ed8a7/attachment-0003.obj>