[Testbot] Plone 4.3 - Python 2.7 - Build # 2269 - Regression! - 1 failure(s)

jenkins at plone.org jenkins at plone.org
Fri May 16 17:20:03 UTC 2014


-------------------------------------------------------------------------------
Plone 4.3 - Python 2.7 - Build # 2269 - Failure!
-------------------------------------------------------------------------------

http://jenkins.plone.org/job/plone-4.3-python-2.7/2269/


-------------------------------------------------------------------------------
CHANGES
-------------------------------------------------------------------------------

Repository: plone.app.jquerytools
Branch: refs/heads/master
Date: 2014-05-15T15:20:36+02:00
Author: Johannes Raggam (thet) <raggam-nl at adm.at>
Commit: https://github.com/plone/plone.app.jquerytools/commit/ff81d76958f980b3d10a62dd0393cdcbea51003d

pep8

Files changed:
M jqt_checkout_build

diff --git a/jqt_checkout_build b/jqt_checkout_build
index bc12cdd..c976a81 100755
--- a/jqt_checkout_build
+++ b/jqt_checkout_build
@@ -9,15 +9,16 @@
 # Added to p.a.jqt by Rok Garbas
 
 
+import StringIO
+import datetime
 import os
 import shlex
 import shutil
-import urllib2
+import subprocess
 import tarfile
 import tempfile
-import StringIO
-import subprocess
-import datetime
+import urllib2
+
 
 JQ_TOOLS_VERSION = 'v1.2.7'
 JQ_TOOLS_DOWNLOAD_URL = 'http://github.com/jquerytools/jquerytools/tarball/'+JQ_TOOLS_VERSION
@@ -32,13 +33,14 @@ def run_hooks(name, hooks, kw):
             kw = hook(**kw)
     return kw
 
+
 def build(name, download_url, hooks=dict(), **kw):
 
     kw['name'] = name
     kw['download_url'] = download_url
 
     # create temporary directory
-    kw['tmp_dir'] = tempfile.mkdtemp(prefix='build--'+name)
+    kw['tmp_dir'] = tempfile.mkdtemp(prefix='build--{}'.format(name))
 
     # download the archive
     archive = urllib2.urlopen(download_url).fp.read()
@@ -64,7 +66,10 @@ def build(name, download_url, hooks=dict(), **kw):
 
         kw['source_dir_name'] = out[0]
         kw['source_dir'] = os.path.join(kw['tmp_dir'], kw['source_dir_name'])
-        kw['build_dir'] = os.path.join(kw['tmp_dir'], kw['source_dir_name']+'-build')
+        kw['build_dir'] = os.path.join(
+            kw['tmp_dir'],
+            '{}-build'.format(kw['source_dir_name'])
+        )
 
         # before hooks
         kw = run_hooks('before', hooks, kw)
@@ -72,7 +77,8 @@ def build(name, download_url, hooks=dict(), **kw):
         for dirpath, dirnames, filenames in os.walk(kw['build_dir']):
             for filename in filenames:
                 kw['filename'] = os.path.join(dirpath, filename)
-                kw['short_filename'] = kw['filename'][len(kw['build_dir']) + 1:]
+                kw['short_filename'] =\
+                    kw['filename'][len(kw['build_dir']) + 1:]
 
                 print '-' * 80
                 print 'FILE: ' + kw['short_filename']
@@ -91,107 +97,122 @@ def build(name, download_url, hooks=dict(), **kw):
 
 def main():
     """
-        master plan:
-         * pull version from http://github.com/jquerytools/jquerytools/tarball/v${VERSION}
-         * untar and make usual build it like ant is doing it (look build.xml)
-         * merge files like its is done in README.txt and copy it to plone/app/jquerytools/browser folder
+    master plan:
+    * pull version from
+      http://github.com/jquerytools/jquerytools/tarball/v${VERSION}
+    * untar and make usual build it like ant is doing it (look build.xml)
+    * merge files like its is done in README.txt and copy it to
+      plone/app/jquerytools/browser folder
     """
-
     # TODO: we could make get values bellow bia sys.args (argparse)
 
-
     PLONE_MAPPING = {
         'jquery.tools.js': [
-                'jquery.tools:overlay/overlay.js',
-                'jquery.tools:scrollable/scrollable.js',
-                'jquery.tools:tabs/tabs.js',
-                'jquery.tools:toolbox/toolbox.history.js',
-                'jquery.tools:toolbox/toolbox.expose.js',
-                'jquery.tools:tooltip/tooltip.js',
-            ],
+            'jquery.tools:overlay/overlay.js',
+            'jquery.tools:scrollable/scrollable.js',
+            'jquery.tools:tabs/tabs.js',
+            'jquery.tools:toolbox/toolbox.history.js',
+            'jquery.tools:toolbox/toolbox.expose.js',
+            'jquery.tools:tooltip/tooltip.js',
+        ],
         'jquery.tools.plugins.js': [
-                'jquery.tools:overlay/overlay.apple.js',
-                'jquery.tools:scrollable/scrollable.autoscroll.js',
-                'jquery.tools:scrollable/scrollable.navigator.js',
-                'jquery.tools:tabs/tabs.slideshow.js',
-                'jquery.tools:toolbox/toolbox.flashembed.js',
-                'jquery.tools:toolbox/toolbox.mousewheel.js',
-                'jquery.tools:tooltip/tooltip.dynamic.js',
-                'jquery.tools:tooltip/tooltip.slide.js',
-            ],
+            'jquery.tools:overlay/overlay.apple.js',
+            'jquery.tools:scrollable/scrollable.autoscroll.js',
+            'jquery.tools:scrollable/scrollable.navigator.js',
+            'jquery.tools:tabs/tabs.slideshow.js',
+            'jquery.tools:toolbox/toolbox.flashembed.js',
+            'jquery.tools:toolbox/toolbox.mousewheel.js',
+            'jquery.tools:tooltip/tooltip.dynamic.js',
+            'jquery.tools:tooltip/tooltip.slide.js',
+        ],
         # 'jquery.tools.dateinput.css': [
-        #         'jquery.tools:dateinput/skin1.css',
+        #     'jquery.tools:dateinput/skin1.css',
         #     ],
         'jquery.tools.dateinput.js': [
-                'jquery.tools:dateinput/dateinput.js',
-            ],
+            'jquery.tools:dateinput/dateinput.js',
+        ],
         'jquery.tools.rangeinput.js': [
-                'jquery.tools:rangeinput/rangeinput.js',
-            ],
+            'jquery.tools:rangeinput/rangeinput.js',
+        ],
         'jquery.tools.validator.js': [
-                'jquery.tools:validator/validator.js',
-            ],
+            'jquery.tools:validator/validator.js',
+        ],
         'jquery.form.js': [
-                'jquery.form:jquery.form.js',
-                ]
+            'jquery.form:jquery.form.js',
+        ]
     }
 
     #
     # run build for all libs
-    build('jquery.tools', JQ_TOOLS_DOWNLOAD_URL,
-          version=JQ_TOOLS_VERSION,
-          plone_mapping=PLONE_MAPPING,
-          today=datetime.datetime.today().strftime("%Y-%m-%d %H:%M"),
-          jslint=os.path.join(os.path.abspath(os.path.dirname(__file__)), 'lib', 'jslint.js'),
-          rhino=os.path.join(os.path.abspath(os.path.dirname(__file__)), 'lib', 'rhino.jar'),
-          compiler=os.path.join(os.path.abspath(os.path.dirname(__file__)), 'lib', 'compiler.jar'),
-          plone_dir=os.path.join(os.path.abspath(os.path.dirname(__file__)), 'plone', 'app', 'jquerytools', 'browser'),
-          hooks = {'before': [
-                        jq_tools_before_hook,
-                        plone_before_hook],
-                   'per_file': [
-                        version_hook,
-                        date_hook,
-                        lint_hook,
-                        minify_hook,
-                        plone_file_hook],
-                  })
-    build('jquery.form', JQ_FORM_URL,
-          plone_mapping=PLONE_MAPPING,
-          today=datetime.datetime.today().strftime("%Y-%m-%d %H:%M"),
-          jslint=os.path.join(os.path.abspath(os.path.dirname(__file__)), 'lib', 'jslint.js'),
-          rhino=os.path.join(os.path.abspath(os.path.dirname(__file__)), 'lib', 'rhino.jar'),
-          compiler=os.path.join(os.path.abspath(os.path.dirname(__file__)), 'lib', 'compiler.jar'),
-          plone_dir=os.path.join(os.path.abspath(os.path.dirname(__file__)), 'plone', 'app', 'jquerytools', 'browser'),
-          hooks = {'before': [
-                        jq_form_before_hook,
-                        plone_before_hook],
-                   'per_file': [
-                        lint_hook,
-                        minify_hook,
-                        plone_file_hook],
-                  })
+    basepath = os.path.abspath(os.path.dirname(__file__))
+    build(
+        'jquery.tools',
+        JQT_DOWNLOAD,
+        version=JQT_VERSION,
+        plone_mapping=PLONE_MAPPING,
+        today=datetime.datetime.today().strftime("%Y-%m-%d %H:%M"),
+        jslint=os.path.join(basepath, 'lib', 'jslint.js'),
+        rhino=os.path.join(basepath, 'lib', 'rhino.jar'),
+        compiler=os.path.join(basepath, 'lib', 'compiler.jar'),
+        plone_dir=os.path.join(
+            basepath, 'plone', 'app', 'jquerytools', 'browser'),
+        hooks={
+            'before': [
+                jq_tools_before_hook,
+                plone_before_hook
+            ],
+            'per_file': [
+                version_hook,
+                date_hook,
+                lint_hook,
+                minify_hook,
+                plone_file_hook
+            ],
+        })
+
+    build(
+        'jquery.form',
+        JQ_FORM_URL,
+        plone_mapping=PLONE_MAPPING,
+        today=datetime.datetime.today().strftime("%Y-%m-%d %H:%M"),
+        jslint=os.path.join(basepath, 'lib', 'jslint.js'),
+        rhino=os.path.join(basepath, 'lib', 'rhino.jar'),
+        compiler=os.path.join(basepath, 'lib', 'compiler.jar'),
+        plone_dir=os.path.join(
+            basepath, 'plone', 'app', 'jquerytools', 'browser'),
+        hooks={
+            'before': [
+                jq_form_before_hook,
+                plone_before_hook
+            ],
+            'per_file': [
+                lint_hook,
+                minify_hook,
+                plone_file_hook
+            ],
+        })
 
 
 def jq_tools_before_hook(**kw):
     shutil.copytree(
-            os.path.join(kw['source_dir'], 'src'),
-            kw['build_dir'])
+        os.path.join(kw['source_dir'], 'src'),
+        kw['build_dir'])
 
     # FIXME: this should actually copy all *.js files from lib directory
     shutil.copy2(
-            os.path.join(kw['source_dir'], 'lib', 'jslint.js'),
-            os.path.join(kw['build_dir'], 'jslint.js'))
-
+        os.path.join(kw['source_dir'], 'lib', 'jslint.js'),
+        os.path.join(kw['build_dir'], 'jslint.js'))
 
     return kw
 
+
 def jq_form_before_hook(**kw):
     shutil.copytree(
-            os.path.join(kw['source_dir']),
-            kw['build_dir'])
+        os.path.join(kw['source_dir']),
+        kw['build_dir'])
     return kw
 
+
 def plone_before_hook(**kw):
     for script in kw['plone_mapping']:
         if not script.startswith(kw['name']):
@@ -208,20 +229,24 @@ def plone_before_hook(**kw):
             f.close()
 
     # FIXME: probably a better way to do this
-    if os.path.exists(os.path.join(kw['source_dir'], 'test', 'dateinput', 'skin1.css')):
+    if os.path.exists(
+            os.path.join(kw['source_dir'], 'test', 'dateinput', 'skin1.css')):
         shutil.copy(
             os.path.join(kw['source_dir'], 'test', 'dateinput', 'skin1.css'),
             os.path.join(kw['build_dir'], 'dateinput'))
     return kw
 
+
 def version_hook(**kw):
     if not kw['filename'].endswith('.js') or \
        kw['filename'].endswith('jslint.js'):
         return kw
-    args_ = shlex.split('sed -i -e "s/@VERSION/%(version)s/g" %(filename)s' % kw)
+    args_ = shlex.split(
+        'sed -i -e "s/@VERSION/%(version)s/g" %(filename)s' % kw)
     subprocess.check_call(args_)
     return kw
 
+
 def date_hook(**kw):
     if not kw['filename'].endswith('.js') or \
        kw['filename'].endswith('jslint.js'):
@@ -231,21 +256,24 @@ def date_hook(**kw):
     subprocess.check_call(args_)
     return kw
 
+
 def lint_hook(**kw):
     if not kw['filename'].endswith('.js') or \
        kw['filename'].endswith('jslint.js'):
         return kw
     # lint (http://www.jslint.com/lint.html)
     output = subprocess.Popen(
-            shlex.split('java -jar %(rhino)s %(jslint)s %(filename)s ' % kw),
-            stdout=subprocess.PIPE).communicate()
+        shlex.split('java -jar %(rhino)s %(jslint)s %(filename)s ' % kw),
+        stdout=subprocess.PIPE
+    ).communicate()
     if output[0].startswith('jslint: No problems found in'):
         print '  |-> jslint status: OK'
     else:
         print '  |-> jslint status: ERROR'
-        print '\n'.join([(' '*6)+i for i in output[0].split('\n')])
+        print '\n'.join([(' ' * 6) + i for i in output[0].split('\n')])
     return kw
 
+
 def minify_hook(**kw):
     if not kw['filename'].endswith('.js') or \
        kw['filename'].endswith('jslint.js'):
@@ -260,21 +288,26 @@ def minify_hook(**kw):
     print '  |-> minified to: ' + kw['short_filename'][:-3] + '.min.js'
     return kw
 
+
 def plone_file_hook(**kw):
-    if (not kw['filename'].endswith('.js') and \
-        not kw['filename'].endswith('.css')) or \
-       kw['filename'].endswith('jslint.js'):
+    if (
+        not kw['filename'].endswith('.js') and
+        not kw['filename'].endswith('.css')
+    ) or kw['filename'].endswith('jslint.js'):
         return kw
     for script in kw['plone_mapping']:
-        if kw['name'] + ':' + kw['short_filename'] in kw['plone_mapping'][script]:
+        if kw['name'] + ':' + kw['short_filename']\
+                in kw['plone_mapping'][script]:
             build_filename = os.path.join(kw['plone_dir'], script)
             if kw['filename'].endswith('.js'):
-                source_filename = os.path.join(kw['build_dir'], kw['short_filename'][:-3] + '.js')
+                source_filename = os.path.join(
+                    kw['build_dir'], kw['short_filename'][:-3] + '.js')
             else:
-                source_filename = os.path.join(kw['build_dir'], kw['short_filename'])
+                source_filename = os.path.join(
+                    kw['build_dir'], kw['short_filename'])
 
             g = open(source_filename)
-            content = g.read()+'\n'
+            content = g.read() + '\n'
             g.close()
 
             f = open(build_filename, 'a+')
@@ -285,10 +318,11 @@ def plone_file_hook(**kw):
 
             if kw['filename'].endswith('.js'):
                 # also do .min.js
-                source_filename = os.path.join(kw['build_dir'], kw['short_filename'][:-3] + '.min.js')
+                source_filename = os.path.join(
+                    kw['build_dir'], kw['short_filename'][:-3] + '.min.js')
 
                 g = open(source_filename)
-                content = g.read()+'\n'
+                content = g.read() + '\n'
                 g.close()
 
                 build_filename = build_filename[:-3] + '.min.js'
@@ -296,7 +330,9 @@ def plone_file_hook(**kw):
                 f.write(content)
                 f.close()
 
-                print '  |-> plone: ' + build_filename[len(kw['plone_dir']) + 1:]
+                print '  |-> plone: {}'.format(
+                    build_filename[len(kw['plone_dir']) + 1:]
+                )
     return kw
 
 


Repository: plone.app.jquerytools
Branch: refs/heads/master
Date: 2014-05-15T15:45:01+02:00
Author: Johannes Raggam (thet) <raggam-nl at adm.at>
Commit: https://github.com/plone/plone.app.jquerytools/commit/e2622522789cf69d0ba80822c7068cc6af2b77d8

use new archive download zipurl instead of tarballs

Files changed:
M jqt_checkout_build

diff --git a/jqt_checkout_build b/jqt_checkout_build
index c976a81..45f71e8 100755
--- a/jqt_checkout_build
+++ b/jqt_checkout_build
@@ -15,16 +15,22 @@ import os
 import shlex
 import shutil
 import subprocess
-import tarfile
 import tempfile
 import urllib2
+import zipfile
 
 
-JQ_TOOLS_VERSION = 'v1.2.7'
-JQ_TOOLS_DOWNLOAD_URL = 'http://github.com/jquerytools/jquerytools/tarball/'+JQ_TOOLS_VERSION
+# JQ_TOOLS_VERSION = 'v1.2.7'
+JQT_VERSION = 'dev'
+JQT_DOWNLOAD =\
+    'https://github.com/jquerytools/jquerytools/archive/{}.zip'.format(
+        JQT_VERSION
+    )
 
-JQ_FORM_VERSION = 'master' # there is no tag
-JQ_FORM_URL= 'http://github.com/malsup/form/tarball/'+JQ_FORM_VERSION
+JQ_FORM_VERSION = 'master'  # there is no tag
+JQ_FORM_URL = 'https://github.com/malsup/form/archive/{}.zip'.format(
+    JQ_FORM_VERSION
+)
 
 
 def run_hooks(name, hooks, kw):
@@ -49,12 +55,13 @@ def build(name, download_url, hooks=dict(), **kw):
     f.seek(0)
 
     # extract it to temporary folder
-    archive_tar = tarfile.open(fileobj=f)
-    for member in archive_tar.getmembers():
-        if member.path.startswith('/') or \
-           member.path.startswith('..'):
+    archive_zip = zipfile.ZipFile(file=f, mode='r')
+    import pdb; pdb.set_trace()
+    for member in archive_zip.namelist():
+        if member.startswith('/') or \
+           member.startswith('..'):
             raise Exception('Somebody wants to harm your coputer.')
-    archive_tar.extractall(kw['tmp_dir'])
+    archive_zip.extractall(path=kw['tmp_dir'])
     f.close()
 
     try:
@@ -90,7 +97,6 @@ def build(name, download_url, hooks=dict(), **kw):
         kw = run_hooks('file', hooks, kw)
 
     finally:
-
         # remove temporary directory
         shutil.rmtree(kw['tmp_dir'])
 


Repository: plone.app.jquerytools
Branch: refs/heads/master
Date: 2014-05-16T17:24:43+02:00
Author: Johannes Raggam (thet) <raggam-nl at adm.at>
Commit: https://github.com/plone/plone.app.jquerytools/commit/cb4e4d8a7b50e3aefd1b3a7692ea72cb47c7f49c

missing changelog entry

Files changed:
M CHANGES.rst

diff --git a/CHANGES.rst b/CHANGES.rst
index f73de3e..f9e0af6 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -4,7 +4,8 @@ Changelog
 1.5.8 (unreleased)
 ------------------
 
-- Nothing changed yet.
+- Switch to zipurls instead tarballs for the build infrastructure.
+  [thet]
 
 
 1.5.7 (2014-02-23)




-------------------------------------------------------------------------------
-------------- next part --------------
A non-text attachment was scrubbed...
Name: CHANGES.log
Type: application/octet-stream
Size: 17119 bytes
Desc: not available
URL: <http://lists.plone.org/pipermail/plone-testbot/attachments/20140516/6b7c80b8/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: build.log
Type: application/octet-stream
Size: 81756 bytes
Desc: not available
URL: <http://lists.plone.org/pipermail/plone-testbot/attachments/20140516/6b7c80b8/attachment-0003.obj>


More information about the Testbot mailing list