[Testbot] Plone 5.0 - Python 2.7 - Build # 2459 - Still failing! - failure(s)

jenkins at plone.org jenkins at plone.org
Wed May 7 13:05:49 UTC 2014


-------------------------------------------------------------------------------
Plone 5.0 - Python 2.7 - Build # 2459 - Still Failing!
-------------------------------------------------------------------------------

http://jenkins.plone.org/job/plone-5.0-python-2.7/2459/


-------------------------------------------------------------------------------
CHANGES
-------------------------------------------------------------------------------

Repository: plone.app.querystring
Branch: refs/heads/master
Date: 2014-05-07T16:07:00+03:00
Author: ichim-david (ichim-david) <ichim.david at gmail.com>
Commit: https://github.com/plone/plone.app.querystring/commit/0a24d379d02669bcb280f3ed9a4bc078cda7e34d

Fixed upgrade_1_to_2 upgrade step in case the registry doesn't contain the
named value

Files changed:
M CHANGES.rst
M plone/app/querystring/upgrades.py

diff --git a/CHANGES.rst b/CHANGES.rst
index 3ff2cb9..5182e65 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -4,6 +4,10 @@ Changelog
 1.2.1 (unreleased)
 ------------------
 
+- Fixed upgrade_1_to_2 upgrade step in case the registry doesn't contain the
+  named value
+  [ichim-david]
+
 - Added show inactive operation which uses the roles vocabulary in order
   to assign permission to show or hide the inactive objects of the given query
   [ichim-david]
diff --git a/plone/app/querystring/upgrades.py b/plone/app/querystring/upgrades.py
index 3d5d5e4..61db057 100644
--- a/plone/app/querystring/upgrades.py
+++ b/plone/app/querystring/upgrades.py
@@ -8,7 +8,9 @@ def upgrade_1_to_2_typo_in_registry(context):
     name = 'plone.app.querystring.field.getObjPositionInParent.operations'
     wrong_value = 'plone.app.querystring.operation.int.greaterThan'
     right_value = 'plone.app.querystring.operation.int.largerThan'
-    values = registry[name]
+    values = registry.get(name)
+    if not values:
+        return
     if wrong_value in values:
         del values[values.index(wrong_value)]
     if right_value not in values:




-------------------------------------------------------------------------------
-------------- next part --------------
A non-text attachment was scrubbed...
Name: CHANGES.log
Type: application/octet-stream
Size: 1546 bytes
Desc: not available
URL: <http://lists.plone.org/pipermail/plone-testbot/attachments/20140507/7235ddd3/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: build.log
Type: application/octet-stream
Size: 4460 bytes
Desc: not available
URL: <http://lists.plone.org/pipermail/plone-testbot/attachments/20140507/7235ddd3/attachment-0001.obj>


More information about the Testbot mailing list