[Testbot] Plone 4.3 - Python 2.6 - Build # 1838 - Improvement! - 1 failure(s)
jenkins at plone.org
jenkins at plone.org
Sun Mar 9 01:24:27 UTC 2014
-------------------------------------------------------------------------------
Plone 4.3 - Python 2.6 - Build # 1838 - Still Failing!
-------------------------------------------------------------------------------
http://jenkins.plone.org/job/plone-4.3-python-2.6/1838/
-------------------------------------------------------------------------------
CHANGES
-------------------------------------------------------------------------------
Repository: plone.batching
Branch: refs/heads/master
Date: 2014-03-08T16:49:13-08:00
Author: David Glick (davisagli) <david at glicksoftware.com>
Commit: https://github.com/plone/plone.batching/commit/c6ecc039cb2258054549e57449104932da21e78a
Revert "Merge pull request #1 from plone/fix-13880"
This reverts commit 1d8abf8bfdd5e39578b3e7a9d9a0186d52a4bd2c, reversing
changes made to 18b5a8a6626575c0a9bbe77b986b667c3c5b247e.
Files changed:
M CHANGES.rst
M plone/batching/batch.py
M plone/batching/tests.py
diff --git a/CHANGES.rst b/CHANGES.rst
index ac9a5fe..9fa2b30 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -4,9 +4,7 @@ Changelog
1.0.2 (unreleased)
------------------
-- Fix issue where a start >= end will always return last item.
- https://dev.plone.org/ticket/13880\
- [thepjot]
+- Nothing changed yet.
1.0.1 (2014-01-27)
diff --git a/plone/batching/batch.py b/plone/batching/batch.py
index 4f1c892..07f4c3d 100644
--- a/plone/batching/batch.py
+++ b/plone/batching/batch.py
@@ -51,8 +51,6 @@ def initialize(self, start, end, size):
self.end = end
self.first = max(start - 1, 0)
- if self.start == self.end and self.sequence_length > 1:
- self.first = self.end
self.length = self.end - self.first
self.last = self.sequence_length - size
diff --git a/plone/batching/tests.py b/plone/batching/tests.py
index 1cbe2a7..2d6e526 100644
--- a/plone/batching/tests.py
+++ b/plone/batching/tests.py
@@ -104,25 +104,6 @@ def test_items_not_on_page(self):
self.assertEqual(list(batch), [5, 6, 7, 8, 9])
- def test_batch_bsize(self):
- sequence = range(279)
- # Random page
- batch = BaseBatch(sequence, 10, start=80)
- self.assertEqual(batch.length, 10)
-
- # Last page
- batch = BaseBatch(sequence, 10, start=270)
- self.assertEqual(batch.length, 9)
-
- # Beyond last page
- batch = BaseBatch(sequence, 10, start=280)
- self.assertEqual(batch.length, 0)
-
- # Single item batch
- batch = BaseBatch(sequence[0:1], 10)
- self.assertEqual(batch.length, 1)
-
-
class TestQuantumBatch(unittest.TestCase):
def test_quantumbatch(self):
-------------------------------------------------------------------------------
-------------- next part --------------
A non-text attachment was scrubbed...
Name: CHANGES.log
Type: application/octet-stream
Size: 2215 bytes
Desc: not available
URL: <http://lists.plone.org/pipermail/plone-testbot/attachments/20140309/ca335a0f/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: build.log
Type: application/octet-stream
Size: 158610 bytes
Desc: not available
URL: <http://lists.plone.org/pipermail/plone-testbot/attachments/20140309/ca335a0f/attachment-0003.obj>
More information about the Testbot
mailing list