[Testbot] Plone 5.0 - Python 2.7 - Build # 2595 - Improvement! - 1 failure(s)

jenkins at plone.org jenkins at plone.org
Wed Jun 18 14:21:20 UTC 2014


-------------------------------------------------------------------------------
Plone 5.0 - Python 2.7 - Build # 2595 - Still Failing!
-------------------------------------------------------------------------------

http://jenkins.plone.org/job/plone-5.0-python-2.7/2595/


-------------------------------------------------------------------------------
CHANGES
-------------------------------------------------------------------------------

Repository: plone.app.linkintegrity
Branch: refs/heads/master
Date: 2014-06-18T14:25:45+02:00
Author: Patrick Gerken (do3cc) <do3cc at patrick-gerken.de>
Commit: https://github.com/plone/plone.app.linkintegrity/commit/79e1580aa4f4234b6d7520bcb0599362ab38d468

fix(ZMI Deletion): Should work now

zmi complained about the missing docstring.
This is a security check in zope when calling methods through the web
When using zmi, deleting something invokes manage_delete...
ttw, then security checks are applied, one is to check for a
non empty docstring. This is why it never should problems in our
tests, we deleted only in plone, where the method gets called
from within python code.
Should fix #14 @jensens

Files changed:
M plone/app/linkintegrity/monkey2.py

diff --git a/plone/app/linkintegrity/monkey2.py b/plone/app/linkintegrity/monkey2.py
index 123bce5..a8eca65 100644
--- a/plone/app/linkintegrity/monkey2.py
+++ b/plone/app/linkintegrity/monkey2.py
@@ -12,8 +12,10 @@
 # which is manage_delObjects
 
 def manage_delObjects(self, ids=None, REQUEST=None):
+    """Checking for docstrings as a security constraint is a very clever idea
+    """
     if REQUEST is not None and not isinstance(ids, basestring):
         REQUEST.set('link_integrity_events_to_expect', len(ids))
     return original(self, ids, REQUEST)
 
-#OFS.ObjectManager.ObjectManager.manage_delObjects = manage_delObjects
+OFS.ObjectManager.ObjectManager.manage_delObjects = manage_delObjects




-------------------------------------------------------------------------------
-------------- next part --------------
A non-text attachment was scrubbed...
Name: CHANGES.log
Type: application/octet-stream
Size: 1467 bytes
Desc: not available
URL: <http://lists.plone.org/pipermail/plone-testbot/attachments/20140618/068d7289/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: build.log
Type: application/octet-stream
Size: 158585 bytes
Desc: not available
URL: <http://lists.plone.org/pipermail/plone-testbot/attachments/20140618/068d7289/attachment-0003.obj>


More information about the Testbot mailing list