[Testbot] Plone 4.3 - Python 2.6 - Build # 2214 - Regression! - 2 failure(s)

jenkins at plone.org jenkins at plone.org
Fri Jul 18 13:51:40 UTC 2014


-------------------------------------------------------------------------------
Plone 4.3 - Python 2.6 - Build # 2214 - Failure!
-------------------------------------------------------------------------------

http://jenkins.plone.org/job/plone-4.3-python-2.6/2214/


-------------------------------------------------------------------------------
CHANGES
-------------------------------------------------------------------------------

Repository: Products.CMFPlone
Branch: refs/heads/4.3.x
Date: 2014-07-18T14:55:12+02:00
Author: Harald Friessnegger (frisi) <harald at webmeisterei.com>
Commit: https://github.com/plone/Products.CMFPlone/commit/a72a9c1fa6d3a41e8578110f6ab6e659bb854cb3

Using the navroot in https://github.com/plone/Products.CMFPlone/commit/359a10d7a22ec842ffd647cc852043fd842c1b8c introduced a bug when the plonesite used VHM:

links to the mail_password_form on login_form contained the portal's path too. eg. plone.org/Plone/mail_password_form

fixed by using navigationRootUrl which respects VHM settings

Files changed:
M Products/CMFPlone/skins/plone_login/login_form.cpt
M docs/CHANGES.rst

diff --git a/Products/CMFPlone/skins/plone_login/login_form.cpt b/Products/CMFPlone/skins/plone_login/login_form.cpt
index 042b422..6eda73c 100644
--- a/Products/CMFPlone/skins/plone_login/login_form.cpt
+++ b/Products/CMFPlone/skins/plone_login/login_form.cpt
@@ -24,7 +24,7 @@
         <metal:login define-macro="login"
             tal:define="auth nocall:context/acl_users/credentials_cookie_auth|context/cookie_authentication|nothing;
                         plone context/@@plone;
-                        nav_root plone/navigationRootPath;
+                        nav_root plone/navigationRootUrl;
                         isURLInPortal nocall:context/portal_url/isURLInPortal;
                         login_template_ids python:'login login_success login_password login_failed login_form logged_in logout logged_out registered mail_password mail_password_form register require_login member_search_results pwreset_finish localhost'.split();
                         came_from request/came_from|request/HTTP_REFERER|nothing;
diff --git a/docs/CHANGES.rst b/docs/CHANGES.rst
index 33c8040..c7768a1 100644
--- a/docs/CHANGES.rst
+++ b/docs/CHANGES.rst
@@ -8,6 +8,9 @@ Changelog
 4.3.4 (unreleased)
 ------------------
 
+- Fix link to the mail_password_form on the login_form for sites using VHM
+  [fRiSi]
+
 - folder_position script: make position and id optional.  Default
   position to 'ordered' and id to None, which means: do nothing.
   plone.folder 1.0.5 allows this, making it possible to simply reverse
@@ -24,7 +27,7 @@ Changelog
 - Fix JavaScript to work with recent jQuery (>= 1.9) versions.
   [thet]
 
-- Improve event_view - do not show time when user specifies the same start and 
+- Improve event_view - do not show time when user specifies the same start and
   end time for an event.
   [spereverde]
 
@@ -221,7 +224,7 @@ Changelog
 - Test for #7627 (https://dev.plone.org/ticket/7627)
 
 4.3rc1 (released)
--------------------
+-----------------
 
 - add overlay for folder default page folder factories link
   [vangheem]




-------------------------------------------------------------------------------
-------------- next part --------------
A non-text attachment was scrubbed...
Name: CHANGES.log
Type: application/octet-stream
Size: 2730 bytes
Desc: not available
URL: <http://lists.plone.org/pipermail/plone-testbot/attachments/20140718/c46cd1d8/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: build.log
Type: application/octet-stream
Size: 167331 bytes
Desc: not available
URL: <http://lists.plone.org/pipermail/plone-testbot/attachments/20140718/c46cd1d8/attachment-0003.obj>


More information about the Testbot mailing list