[Testbot] Plone 5.0 - Python 2.7 - Build # 1326 - Still failing! - 1 failure(s)

jenkins at plone.org jenkins at plone.org
Wed Jan 29 18:17:35 UTC 2014


This commit violated the Plone Continous Integration rule "Don’t Check In on a Broken Build": https://buildoutcoredev.readthedocs.org/en/latest/continous-integration.html#dont-check-in-on-a-broken-build

-------------------------------------------------------------------------------

-------------------------------------------------------------------------------
Plone 5.0 - Python 2.7 - Build # 1326 - Still Failing!
-------------------------------------------------------------------------------

http://jenkins.plone.org/job/plone-5.0-python-2.7/1326/


-------------------------------------------------------------------------------
CHANGES
-------------------------------------------------------------------------------

Repository: plone.app.users
Branch: refs/heads/master
Date: 2014-01-28T12:13:51-08:00
Author: Thomas Desvenain (tdesvenain) <thomas.desvenain at gmail.com>
Commit: https://github.com/plone/plone.app.users/commit/53e6f7b2416412dd5af9b3aa48fc95d4ad10b722

Reload form after submission (this makes portrait widget refresh after edit)

Files changed:
M plone/app/users/browser/account.py

diff --git a/plone/app/users/browser/account.py b/plone/app/users/browser/account.py
index eca894f..cb16d49 100644
--- a/plone/app/users/browser/account.py
+++ b/plone/app/users/browser/account.py
@@ -140,7 +140,6 @@ def validate_email(self, action, data):
     @button.buttonAndHandler(_(u'Save'))
     def handleSave(self, action):
         CheckAuthenticator(self.request)
-
         data, errors = self.extractData()
 
         # extra validation for email
@@ -158,6 +157,7 @@ def handleSave(self, action):
         else:
             IStatusMessage(self.request).addStatusMessage(
                 self.noChangesMessage, type='info')
+        self.request.response.redirect(self.request['ACTUAL_URL'])
 
     @button.buttonAndHandler(_(u'Cancel'))
     def cancel(self, action):


Repository: plone.app.users
Branch: refs/heads/master
Date: 2014-01-28T12:14:55-08:00
Author: Thomas Desvenain (tdesvenain) <thomas.desvenain at gmail.com>
Commit: https://github.com/plone/plone.app.users/commit/6814b77ecc96f486ca033ccaf2b1383259ee4bf3

portrait attribute field adapter gives a NamedBlobImage so it is compatible with image validator

Files changed:
M plone/app/users/browser/userdatapanel.py

diff --git a/plone/app/users/browser/userdatapanel.py b/plone/app/users/browser/userdatapanel.py
index 9b65f10..00a33f5 100644
--- a/plone/app/users/browser/userdatapanel.py
+++ b/plone/app/users/browser/userdatapanel.py
@@ -7,6 +7,7 @@
 from plone.app.users.browser.account import AccountPanelForm
 from plone.app.users.browser.account import AccountPanelSchemaAdapter
 from plone.app.users.schema import IUserDataSchema
+from plone.namedfile.file import NamedBlobImage
 
 
 class UserDataPanelAdapter(AccountPanelSchemaAdapter):
@@ -24,16 +25,17 @@ def get_portrait(self):
                                                default_portrait,
                                                None)):
             return None
-        return value
+        return NamedBlobImage(value.data, contentType=value.content_type,
+                              filename=getattr(value, 'filename', None))
 
     def set_portrait(self, value):
         mt = getToolByName(self.context, 'portal_membership')
         if value is None:
             mt.deletePersonalPortrait(str(self.context.getId()))
         else:
-            file = value.open()
-            file.filename = value.filename
-            mt.changeMemberPortrait(file, str(self.context.getId()))
+            portrait_file = value.open()
+            portrait_file.filename = value.filename
+            mt.changeMemberPortrait(portrait_file, str(self.context.getId()))
 
     portrait = property(get_portrait, set_portrait)
 


Repository: plone.app.users
Branch: refs/heads/master
Date: 2014-01-28T12:15:31-08:00
Author: Thomas Desvenain (tdesvenain) <thomas.desvenain at gmail.com>
Commit: https://github.com/plone/plone.app.users/commit/c51e61f1da7135a08202ba4cb35f043a1864e9a2

ignore eclipse files

Files changed:
M .gitignore

diff --git a/.gitignore b/.gitignore
index d469ee4..bc372d9 100644
--- a/.gitignore
+++ b/.gitignore
@@ -5,3 +5,5 @@ include
 lib
 develop-eggs
 parts
+*.pydevproject
+*.project


Repository: plone.app.users
Branch: refs/heads/master
Date: 2014-01-29T09:25:39-08:00
Author: David Glick (davisagli) <david at glicksoftware.com>
Commit: https://github.com/plone/plone.app.users/commit/ce71f36c4db1b1a753b714ddfef550eca97077b6

Merge pull request #16 from tdesvenain/master

Compatibility with new plone.namedfile image field validator

Files changed:
M .gitignore
M plone/app/users/browser/account.py
M plone/app/users/browser/userdatapanel.py

diff --git a/.gitignore b/.gitignore
index d469ee4..bc372d9 100644
--- a/.gitignore
+++ b/.gitignore
@@ -5,3 +5,5 @@ include
 lib
 develop-eggs
 parts
+*.pydevproject
+*.project
diff --git a/plone/app/users/browser/account.py b/plone/app/users/browser/account.py
index eca894f..cb16d49 100644
--- a/plone/app/users/browser/account.py
+++ b/plone/app/users/browser/account.py
@@ -140,7 +140,6 @@ def validate_email(self, action, data):
     @button.buttonAndHandler(_(u'Save'))
     def handleSave(self, action):
         CheckAuthenticator(self.request)
-
         data, errors = self.extractData()
 
         # extra validation for email
@@ -158,6 +157,7 @@ def handleSave(self, action):
         else:
             IStatusMessage(self.request).addStatusMessage(
                 self.noChangesMessage, type='info')
+        self.request.response.redirect(self.request['ACTUAL_URL'])
 
     @button.buttonAndHandler(_(u'Cancel'))
     def cancel(self, action):
diff --git a/plone/app/users/browser/userdatapanel.py b/plone/app/users/browser/userdatapanel.py
index 9b65f10..00a33f5 100644
--- a/plone/app/users/browser/userdatapanel.py
+++ b/plone/app/users/browser/userdatapanel.py
@@ -7,6 +7,7 @@
 from plone.app.users.browser.account import AccountPanelForm
 from plone.app.users.browser.account import AccountPanelSchemaAdapter
 from plone.app.users.schema import IUserDataSchema
+from plone.namedfile.file import NamedBlobImage
 
 
 class UserDataPanelAdapter(AccountPanelSchemaAdapter):
@@ -24,16 +25,17 @@ def get_portrait(self):
                                                default_portrait,
                                                None)):
             return None
-        return value
+        return NamedBlobImage(value.data, contentType=value.content_type,
+                              filename=getattr(value, 'filename', None))
 
     def set_portrait(self, value):
         mt = getToolByName(self.context, 'portal_membership')
         if value is None:
             mt.deletePersonalPortrait(str(self.context.getId()))
         else:
-            file = value.open()
-            file.filename = value.filename
-            mt.changeMemberPortrait(file, str(self.context.getId()))
+            portrait_file = value.open()
+            portrait_file.filename = value.filename
+            mt.changeMemberPortrait(portrait_file, str(self.context.getId()))
 
     portrait = property(get_portrait, set_portrait)
 




-------------------------------------------------------------------------------

-------------- next part --------------
A non-text attachment was scrubbed...
Name: CHANGES.log
Type: application/octet-stream
Size: 6444 bytes
Desc: not available
URL: <http://lists.plone.org/pipermail/plone-testbot/attachments/20140129/fd5aea11/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: build.log
Type: application/octet-stream
Size: 132244 bytes
Desc: not available
URL: <http://lists.plone.org/pipermail/plone-testbot/attachments/20140129/fd5aea11/attachment-0003.obj>


More information about the Testbot mailing list