[Testbot] Plone 5.0 - Python 2.7 - Build # 2386 - Regression! - 9 failure(s)

jenkins at plone.org jenkins at plone.org
Thu Apr 24 13:40:11 UTC 2014


-------------------------------------------------------------------------------
Plone 5.0 - Python 2.7 - Build # 2386 - Still Failing!
-------------------------------------------------------------------------------

http://jenkins.plone.org/job/plone-5.0-python-2.7/2386/


-------------------------------------------------------------------------------
CHANGES
-------------------------------------------------------------------------------

Repository: plone.app.layout
Branch: refs/heads/master
Date: 2014-04-24T14:46:03+02:00
Author: Ramon Navarro Bosch (bloodbare) <ramon.nb at gmail.com>
Commit: https://github.com/plone/plone.app.layout/commit/549dc788c5190b6023618a46cb2b0bcfffb75f28

Global navigation and breadcrumbs and ARIA

Files changed:
M plone/app/layout/viewlets/path_bar.pt
M plone/app/layout/viewlets/sections.pt

diff --git a/plone/app/layout/viewlets/path_bar.pt b/plone/app/layout/viewlets/path_bar.pt
index 1f657b1..c157e46 100644
--- a/plone/app/layout/viewlets/path_bar.pt
+++ b/plone/app/layout/viewlets/path_bar.pt
@@ -1,30 +1,32 @@
-<section id="portal-breadcrumbs"
+<nav id="portal-breadcrumbs" class="breadcrumb" role="navigation"
          i18n:domain="plone"
          tal:define="breadcrumbs view/breadcrumbs">
+  <div class="container-fluid">
 
-  <span id="breadcrumbs-you-are-here"
-        i18n:translate="you_are_here">You are here:</span>
-  <ol>
-    <li id="breadcrumbs-home">
-      <a i18n:translate="tabs_home"
-         tal:attributes="href view/navigation_root_url">Home</a>
-    </li>
-    <li tal:repeat="crumb breadcrumbs"
-        tal:attributes="id string:breadcrumbs-${repeat/crumb/number};">
-      <tal:item tal:define="is_last repeat/crumb/end;
-                            url crumb/absolute_url;
-                            title crumb/Title">
-        <a href="#"
-           tal:omit-tag="not: url"
-           tal:condition="python:not is_last"
-           tal:attributes="href url"
-           tal:content="title">
-            crumb
-        </a>
-        <span id="breadcrumbs-current"
-              tal:condition="is_last"
-              tal:content="title">crumb</span>
-      </tal:item>
-    </li>
-  </ol>
-</section>
+      <span id="breadcrumbs-you-are-here"
+            i18n:translate="you_are_here">You are here:</span>
+      <ol aria-labelledby="breadcrumbs-you-are-here">
+        <li id="breadcrumbs-home">
+          <a i18n:translate="tabs_home"
+             tal:attributes="href view/navigation_root_url">Home</a>
+        </li>
+        <li tal:repeat="crumb breadcrumbs"
+            tal:attributes="id string:breadcrumbs-${repeat/crumb/number};">
+          <tal:item tal:define="is_last repeat/crumb/end;
+                                url crumb/absolute_url;
+                                title crumb/Title">
+            <a href="#"
+               tal:omit-tag="not: url"
+               tal:condition="python:not is_last"
+               tal:attributes="href url"
+               tal:content="title">
+                crumb
+            </a>
+            <span id="breadcrumbs-current"
+                  tal:condition="is_last"
+                  tal:content="title">crumb</span>
+          </tal:item>
+        </li>
+      </ol>
+  </div>
+</nav>
diff --git a/plone/app/layout/viewlets/sections.pt b/plone/app/layout/viewlets/sections.pt
index e5cfa9f..79c3289 100644
--- a/plone/app/layout/viewlets/sections.pt
+++ b/plone/app/layout/viewlets/sections.pt
@@ -1,19 +1,40 @@
-<tal:sections tal:define="portal_tabs view/portal_tabs"
+<tal:sections 
+     xmlns:tal="http://xml.zope.org/namespaces/tal"
+     xmlns:metal="http://xml.zope.org/namespaces/metal"
+     xmlns:i18n="http://xml.zope.org/namespaces/i18n"
+     tal:define="portal_tabs view/portal_tabs"
      tal:condition="portal_tabs"
      i18n:domain="plone">
     <p class="hiddenStructure" i18n:translate="heading_sections">Navigation</p>
+    <nav class="navbar" id ="portal-globalnav-wrapper" role="navigation">
 
-    <ul id="portal-globalnav"
-        tal:define="selected_tab python:view.selected_portal_tab"
-        ><tal:tabs tal:repeat="tab portal_tabs"
-        ><li tal:define="tid tab/id"
-             tal:attributes="id string:portaltab-${tid};
-                            class python:selected_tab==tid and 'selected' or 'plain'"
-            ><a href=""
-               tal:content="tab/name"
-               tal:attributes="href tab/url;
-                               title tab/description|nothing;
-                               target tab/link_target|nothing;">
-            Tab Name
-            </a></li></tal:tabs></ul>
+        <div class="navbar-header">
+          <button type="button" class="navbar-toggle" data-toggle="collapse" data-target="#portal-globalnav-collapse">
+            <span class="sr-only">Toggle navigation</span>
+            <span class="icon-bar"></span>
+            <span class="icon-bar"></span>
+            <span class="icon-bar"></span>
+          </button>
+        </div>
+
+        <div class="collapse navbar-collapse" id="portal-globalnav-collapse">
+          <ul class="nav navbar-nav" 
+              id="portal-globalnav" 
+              tal:define="selected_tab python:view.selected_portal_tab">
+              <tal:tabs tal:repeat="tab portal_tabs">
+                <li tal:define="tid tab/id"
+                    tal:attributes="id string:portaltab-${tid};
+                                    class python:selected_tab==tid and 'selected' or 'plain'">
+                    <a href=""
+                       tal:content="tab/name"
+                       tal:attributes="href tab/url;
+                                       title tab/description|nothing;
+                                       target tab/link_target|nothing;">
+                      Tab Name
+                    </a>
+                </li>
+              </tal:tabs>
+          </ul>
+        </div>
+    </nav>
 </tal:sections>




-------------------------------------------------------------------------------
-------------- next part --------------
A non-text attachment was scrubbed...
Name: CHANGES.log
Type: application/octet-stream
Size: 5491 bytes
Desc: not available
URL: <http://lists.plone.org/pipermail/plone-testbot/attachments/20140424/a05d61eb/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: build.log
Type: application/octet-stream
Size: 106954 bytes
Desc: not available
URL: <http://lists.plone.org/pipermail/plone-testbot/attachments/20140424/a05d61eb/attachment-0003.obj>


More information about the Testbot mailing list