[Product-Developers] plone.app.ldap master: Plone 4 only?

[Alex Clark]

On 2012-09-24 14:28:45 +0000, Maurits van Rees said:

> Hi,
> 
> plone.app.ldap is on github already:
> https://github.com/plone/plone.app.ldap
> 
> The master currently does not support Plone 3, though that is easy 
> tofix by doing '<include package="Products.CMFCore" />' instead 
> of'<include package="Products.CMFCore" file="permissions.zcml" />.
> 
> But there are several zope.app imports.  These will break in Plone 
> 4.3unless we add those dependencies explicitly in setup.py or add 
> backwardscompatible imports, with this familiar pattern:
> 
> try:
>      from zope.component.hooks import getSite
>      getSite  # pyflakes
> except ImportError:
>      # BBB for Plone 3, if we still need to support that.
>      from zope.app.component.hooks import getSite
> 
> If it were just one import then this would be fine, but there are morethan ten.
> 
> So I say we officially drop support for Plone 3 on master.  Is 
> anyoneagainst that?
> 
> I am guessing that due to the dependency cleanup in the upcoming 
> Plone4.3 this will be a natural point at which add-on developers will 
> nolonger support Plone 3 because of this extra hassle.
> 
> BTW, master currently has a fix by sneridagh (Víctor Fernández de 
> Alba)that would be good to have in a release.  Hint: PyPI rights for 
> usermaurits at http://pypi.python.org/pypi/plone.app.ldap would be 
> gladlyaccepted. :-)


+1 I had already assumed that to be the case… IIRC the docs say 
something like plone.app.ldap on Plone 3 use 1.2.x only but there is no 
1.3 release :-)


> 
> Thanks,


-- 
Alex Clark · http://pythonpackages.com