[Product-Developers] Re: five.intid tests are failing

Johannes Raggam raggam-nl at adm.at
Tue Jan 19 15:13:16 UTC 2010


it was me who updated all deprecated imports to the new zope2.12 API.
all tests (except tracking.txt) were working for zope2.12/plone4.
unfortunately this broke the compatibility with zope<2.12.

now i restored zope2.12 compatibility, but the tests are broken now - as
it was before my changes. i tried to run five.intid's revision 92750
tests with plone3.3.4  and there are exactly the same test failures like
now, with the restored zope<2.12 compatibility.
but these are too much failures for me today...

in my opinion, we should tag rev92750 or rev108291 for plone3 support
and drop plone3 support in trunk at all. this should be feasable, since
most people should get five.intid via pypi.

what do you think?


PLEASE NOTE:
i updated setup.py to have test-support via extras_require.

and please note that checking out a specific revision with mr.developer
seems not to work. it does only a checkout at the given revision on the
files that were changed at this revision. all other files are checked
out with the newest version available. you have to do it with
svn co -r92750 https://svn.plone.org/svn/collective/five.intid/trunk/


my buildout.cfg has following changes from
http://svn.plone.org/svn/plone/plonenext/3.3/buildout.cfg

thet at thet-nano:~/dev-python/plone/3.3$ svn diff buildout.cfg 
Index: buildout.cfg
===================================================================
--- buildout.cfg	(revision 33236)
+++ buildout.cfg	(working copy)
@@ -1,6 +1,9 @@
 [buildout]
-parts = instance 
-extensions = buildout.eggtractor
+parts = instance test
+extensions = buildout.eggtractor mr.developer
+always-checkout = true
+auto-checkout = five.intid
+
 allow-picked-versions = false
 tractor-autoload-zcml = false
 extends = versions.cfg
@@ -16,6 +19,11 @@
 download-directory = ${buildout:directory}/download
 download-cache = ${buildout:directory}/download
 
+eggs =
+    Plone
+    PIL
+    five.intid
+
 # Version pins that are plonenext-specific, and unused in core Plone
installs
 [versions]
 buildout.eggtractor = 0.6
@@ -23,6 +31,7 @@
 [zope2]
 recipe = plone.recipe.zope2install
 url = ${versions:zope2-url}
+fake-zope-eggs = true
 
 [instance]
 recipe = plone.recipe.zope2instance
@@ -32,6 +41,13 @@
 verbose-security = on
 http-address = 127.0.0.1:8080
 eggs =
-    Plone
-    PIL
-    
+    ${buildout:eggs}
+
+[sources]
+five.intid = svn https://svn.plone.org/svn/collective/five.intid/trunk
+# ref=108291
+
+[test]
+recipe = zc.recipe.testrunner
+extra-paths = ${zope2:location}/lib/python
+eggs = five.intid [test]





On Mon, 2010-01-18 at 21:25 +0100, Wichert Akkerman wrote:
> I was looking at fixing a few deprecation warnings for five.intid for 
> Plone 4/Zope 2.12. Unfortuantely it seems five.intid tests are in a bad 
> shape: with Plone 3.3.4 they fail like this:
> 
> Traceback (most recent call last):
>    File 
> "/Users/wichert/Work/syslab/euphorie/buildout/devel/src/five.intid/five/intid/tests.py", 
> line 6, in ?
>      from zope.site.hooks import setHooks, setSite
>    File 
> "/Users/wichert/Library/eggs/zope.site-3.6.1-py2.4.egg/zope/site/__init__.py", 
> line 19, in ?
>      from zope.site.site import (SiteManagerContainer, SiteManagementFolder,
>    File 
> "/Users/wichert/Library/eggs/zope.site-3.6.1-py2.4.egg/zope/site/site.py", 
> line 44, in ?
>      from zope.site import interfaces
>    File 
> "/Users/wichert/Library/eggs/zope.site-3.6.1-py2.4.egg/zope/site/interfaces.py", 
> line 87, in ?
>      class IRootFolder(IFolder, zope.location.interfaces.IRoot):
> AttributeError: 'module' object has no attribute 'IRoot'
> 
> and on Plone 4 all tracking.txt tests fail like this:
> 
> Failed example:
>      print http(r"""
>      POST /++etc++site/default/@@contents.html HTTP/1.1
>      Authorization: Basic mgr:mgrpw
>      Referer: http://localhost:8081/++etc++site/default/@@contents.html
> 
>      type_name=BrowserAdd__zope.intid.IntIds&new_value=""")
> Expected:
>      HTTP/1.1 303 See Other
>      ...
>      Location: 
> http://localhost/++etc++site/default/IntIds/@@registration.html
>      ...
> Got:
>      HTTP/1.1 404 Not Found
>      Content-Length: 738
>      Content-Type: text/html; charset=iso-8859-15
> 
> I've cc'ed the people who last touched five.intid; hopefully one of you 
> will recognize these errors and can fix them.
> 
> Wichert.
> 






More information about the Product-Developers mailing list