[Product-Developers] Re: Integrating collective.carousel and collective.contentleadimage

[Dylan Jay]

On 17/02/2010, at 9:08 PM, Denys Mishunov wrote:

> Hello,
>
> On Wed, Feb 17, 2010 at 10:22 AM, Harald Friessnegger
> <harald at webmeisterei.com> wrote:
>> hi dylan
>>
>> somehow an import of collective.leadimage made it into trunk with
>> http://dev.plone.org/collective/changeset/111097/
>>
>> the import should be conditional to not break collective.carousel  
>> for people
>> that did not install leadimage.
>
> That is correct Harald.
> Dylan, I have reverted your changes in trunk - please keep your code
> in branch for now. If you need that package you can build such
> dependency for yourself of course. But this doesn't belong to
> collective.carousel if you don't make check up of whether
> collective.contentleadimage is available or not. Please don't break
> the package even if it.
>
> Moreover we have a project dependent on this package (c.carousel) and
> you just change too much stuff as for a simple new tile - template,
> CSS, JS. Please keep such changes in branch for now. Otherwise sites
> that already use this package will need to be updated or will be
> broken (as with collective.contentleadimage dependency).

I'm really sorry. I haven't used svn in over a year and obviously made  
a mistake committing to the branch. It wasn't my intention to commit  
to trunk.


>
> -- 
> Best regards,
> Denys Mishunov
>
> mailto:denys.mishunov at gmail.com
> IRC: spliter(#plone)
>
> _______________________________________________
> Product-Developers mailing list
> Product-Developers at lists.plone.org
> http://lists.plone.org/mailman/listinfo/product-developers