[Product-Developers] Re: collective.loadtesting failed on zope.testing.testrunner

[JeanMichel FRANCOIS]

> You got it!  The 3.6.0 release of zope.testing refactored the large
> testrunner.py file into a testrunner/__init__.py package.  I've put a
> 'zope.testing>=3.6' requirement into setup.py.
>
> Ross

Thank you Ross for that fix.

I have also failed at using build-diffs script from funkload.

Here is the trace:

./bin/build-diffs  var/reports
Creating diff report ...done:
Traceback (most recent call last):
  File "./bin/build-diffs", line 17, in ?
    collective.funkload.diff.main()
  File 
"/home/toutpt/workspace/performanceplone/guerir.loadtesting/src/collective.funkload/src/collective/funkload/diff.py", 
line 125, in main
    return run(reports_dir)
  File 
"/home/toutpt/workspace/performanceplone/guerir.loadtesting/src/collective.funkload/src/collective/funkload/diff.py", 
line 112, in run
    build_diff(reports_dir, prev_path, latest_path)
  File 
"/home/toutpt/workspace/performanceplone/guerir.loadtesting/src/collective.funkload/src/collective/funkload/diff.py", 
line 44, in build_diff
    utils.trace("file://%s\n" % html_path)
  File 
"/home/toutpt/workspace/performanceplone/guerir.loadtesting/src/funkload/src/funkload/ReportRenderDiff.py", 
line 133, in __repr__
    return self.render()
  File 
"/home/toutpt/workspace/performanceplone/guerir.loadtesting/src/funkload/src/funkload/ReportRenderHtmlBase.py", 
line 124, in render
    self.prepareReportDirectory()
  File 
"/home/toutpt/workspace/performanceplone/guerir.loadtesting/src/funkload/src/funkload/ReportRenderHtmlBase.py", 
line 67, in prepareReportDirectory
    if self.options.report_dir:
AttributeError: 'str' object has no attribute 'report_dir'


Here the patch i have done:

Index: src/funkload/src/funkload/ReportRenderHtmlBase.py
===================================================================
--- src/funkload/src/funkload/ReportRenderHtmlBase.py   (révision 53547)
+++ src/funkload/src/funkload/ReportRenderHtmlBase.py   (copie de travail)
@@ -64,7 +64,9 @@

     def prepareReportDirectory(self):
         """Create a report directory."""
-        if self.options.report_dir:
+        if isinstance(self.options, str):
+            report_dir = os.path.join(os.getcwd(), self.options)
+        elif self.options.report_dir:
             report_dir = os.path.abspath(self.options.report_dir)
         else:
             # init output dir

But i currently don't understand what build-diffs is doing, because i have 5 
reports and i get only one diff report.

Last question, i have seen that funkload used in collective.loadtesting is 
branche called 'tomster-fix' but it's seems to be the 1.9.1 release, is this 
right ? do you plan a release of this egg ? I have try to use the egg from 
pypi but it doesn't work with the current tests.

JeanMichel FRANCOIS
Makina-Corpus

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.plone.org/pipermail/plone-product-developers/attachments/20090317/6a9347c5/attachment.html>