[Product-Developers] Re: making collective.flowplayer less invasive

Martin Aspeli optilude at gmail.com
Tue Mar 17 02:20:35 UTC 2009


Hi David,

> I've just been reviewing the collective.flowplayer code as part of the  
> process for approving it for use on our Plone sites.  It looks great,  
> with one exception: we host many Plone sites in one Zope instance, and  
> want to selectively install collective.flowplayer to only some of  
> those sites.  Based on inspection of the code, it looks like there are  
> two ways in which collective.flowplayer will pollute the other sites:
> 
> 1. It registers various browser views without specifying a browser  
> layer.

I don't generally have a problem with this, if nothing is linking to 
those views without the product installed. I think that's pretty common 
practice.

It's obviously a different story for viewlets.

> 2. It subtypes objects in response to object events without checking  
> to make sure that the object is within a site that has  
> collective.flowplayer installed.

That would be a good thing to fix, definitely.

> Both of these should be pretty easy to fix...Can we do that?

Absolutely!

Martin




More information about the Product-Developers mailing list