[PLIP-Advisories] [Plone development workspace] #10804: include workflow manager

[Change notifications for Plone PLIPs on Trac.]

#10804: include workflow manager
-----------------------+-----------------------
  Reporter:  vangheem  |      Owner:  vangheem
      Type:  PLIP      |     Status:  confirmed
  Priority:  n/a       |  Milestone:  4.3
 Component:  Unknown   |    Version:  4.3
Resolution:            |   Keywords:
-----------------------+-----------------------

Comment (by davisagli):

 Here are some notes from trying out the workflow manager. I haven't
 reviewed the code yet.

 * How come the initial page only lets me create a new workflow, not select
 one of the ones that ships with Plone? If the goal is to avoid breaking
 the core workflows, it would be nice if the user could at least look at
 them ready-only.
 * Creating a new workflow should default to cloning the workflow that is
 set as default.
 * The floating toolbar and turning the Save button red after a change are
 nice touches. (But it stays red if I edited a transition and then jump to
 states without saving...not sure if clicking now will save what I changed
 or not...)
 * Assigning a workflow to a type is a little wonky. We should probably
 take the workflow reassignment state thingy out of the Types control panel
 and make it its own form. Also, I'm thinking it would be good if the
 initial page of the workflow manager gave an overview of what workflows
 exist and what types use them. (Something like the table that lists all
 Dexterity types on the initial page of the Dexterity type editor.)
 * It would be good if there were more inline help text to get people
 oriented in this complicated UI. (For example, the initial page should say
 something about what workflow is and how to proceed if you want to change
 the default workflow for a type in Plone.)
 * I didn't spend a lot of time trying to break it; I assume it works since
 it's been available as an add-on for some time.
 * Updating security may be "advanced" in a sense, but it's also an
 important part of editing workflow if you have existing items using the
 workflow. I think we need a better way to warn people that this is
 necessary and that it will take a while.

 Nitpicky things:
 * Should probably have a unique icon in the control panel
 * The bootstrap styling looks nice in isolation, but is a bit weird since
 it's not used elsewhere in Plone. I think if we made the status message
 and button have their normal Plone styles, it would help.
 * The blue boxes labeled Transitions and State are confusing because they
 look like buttons but aren't. Maybe kill the background color and just
 have it be bold text with a colon at the end, so it looks more like a
 label for the list that follows.
 * The "Assigned Types: | * denotes initial state of this workflow" line at
 the bottom is confusing. This is 2 things which should go on separate
 lines.

-- 
Ticket URL: <http://dev.plone.org/ticket/10804#comment:14>
Plone development workspace <https://dev.plone.org/>
Plone Enterprise Content Management System