[PLIP-Advisories] Re: [Plone] #7822: Make standard file content types use ZODB BLOB support

plip-advisories at lists.plone.org plip-advisories at lists.plone.org
Wed Sep 30 14:55:53 UTC 2009


#7822: Make standard file content types use ZODB BLOB support
----------------------------+-----------------------------------------------
 Reporter:  limi            |        Owner:  witsch  
     Type:  PLIP            |       Status:  assigned
 Priority:  major           |    Milestone:  4.0     
Component:  Infrastructure  |   Resolution:          
 Keywords:  focusarea       |  
----------------------------+-----------------------------------------------

Comment(by witsch):

 Replying to [comment:44 optilude]:
 > (In [29687]) PLIP review refs #7822

 again, quoting parts of [browser:buildouts/plone-
 coredev/branches/4.0/plips/plip7822-review-optilude.txt at 29687 martin's
 review] to be able to provide comments inline:

 > * We should make BLOB files and images the default for non-migrated
 sites.

 as already mentioned, this is the case as of r30057.  new content will use
 blobs, old content will remain untouched and functional, and can be
 updated using the provided migration views.

 > * The "plone.app.blob: Add Blob" permission needs to be granted to
 >   Owner, Manager, Contributor by default. It's not entirely clear how
 this
 >   relates to the "ATContentTypes: Add Image" and "ATContentTypes: Add
 File"
 >   permissions. I think ideally, we shouldn't have special permissions
 for
 >   blobs, but if we do, we need to document how these three permissions
 >   relate.

 this was in fact a bug, that has been fixed in the meantime (see r29875).
 the new types should use the original permissions, i.e. "ATContentTypes:
 Add File" etc, in order to be fully compatible with existing sites.
 unfortunately, the bug was nicely hidden away due to the way test layers
 are stacked up.

 > * The "w/o blobs" types appear in the "types" control panel. They
 shouldn't
 >   by default.

 i'm not sure if the FTIs need to be present for existing, unmigrated
 content.  if not, i can make sure they're not exposed anymore.  hmm,
 unless i've misread this so far and it is the plone control panel you're
 referring to here?  in this case, yes, they should not be visible.

 > * I installed plone.app.blob, and turned on automatic versioning. I then
 >   uploaded a file. It suceeded, but I got this in the logs:
 >
 >   Exception OSError: (2, 'No such file or directory',
 '/var/folders/CS/CSVVQU2TGaiQYSKA+4-NNE+++TI/-Tmp-/tmpsUGy_l') in <bound
 method _TemporaryFileWrapper.__del__ of <closed file '<fdopen>', mode
 'w+b' at 0x32f1de0>> ignored

 the fixed version of the monkey patch wasn't properly applied in Zope
 2.12. this was fixed in r30019 — the message shouldn't appear anymore.

 > * I uploaded an image, then used the transform tab to rotate it 90
 degrees.
 >   This caused an error:

 this is a known issue and will have to be addressed (see ticket #8506).
 the fix should be rather straight-forward, though — i think i have a patch
 someone sent me for this.

 > * For migrated sites, we should make it opt-in to migrate to BLOB types.

 this is already the case for existing content.  or do you mean using blobs
 for new content should also be opt-in (for existing sites)?

-- 
Ticket URL: <http://dev.plone.org/plone/ticket/7822#comment:62>
Plone <http://plone.org>
Plone Content Management System


More information about the PLIP-Advisories mailing list