[PLIP-Advisories] Re: [Plone] #9316: Unify folder implementations

plip-advisories at lists.plone.org plip-advisories at lists.plone.org
Fri Oct 2 20:35:02 UTC 2009


#9316: Unify folder implementations
----------------------------+-----------------------------------------------
 Reporter:  smcmahon        |        Owner:  witsch  
     Type:  PLIP            |       Status:  assigned
 Priority:  n/a             |    Milestone:  4.0     
Component:  Infrastructure  |   Resolution:          
 Keywords:                  |  
----------------------------+-----------------------------------------------

Comment(by witsch):

 Replying to [comment:36 davisagli]:
 > I'm still seeing the issues you mentioned in the ATContentTypes and
 Archetypes tests,

 yes, i didn't have time to look into them yet.

 > as well as some in the CMFEditions tests.

 these errors like
 {{{
 #!python
 Error in test test07_prepareObjectWithReferences
 (Products.CMFEditions.tests.test_ArchivistTool.TestArchivistToolZStorage)
 Traceback (most recent call last):
   File ".../lib/python2.6/unittest.py", line 279, in run
     testMethod()
   File
 ".../Products.CMFEditions/Products/CMFEditions/tests/test_ArchivistTool.py",
 line 247, in test07_prepareObjectWithReferences
     for sub in cloneValues:
   File ".../Products/ZCatalog/Lazy.py", line 158, in __getitem__
     data.append(func(s[ind]))
   File ".../plone.folder/src/plone/folder/ordered.py", line 44, in _getOb
     return super(OrderedBTreeFolderBase, self)._getOb(id, default)
   File ".../Products/BTreeFolder2/BTreeFolder2.py", line 221, in _getOb
     return ob.__of__(self)
 AttributeError: __of__
 }}}
 also occur in plone 4.0 and 3.3 with the following patch
 {{{
 #!patch
 Index:
 src/Products.CMFEditions/Products/CMFEditions/tests/test_ArchivistTool.py
 ===================================================================
 ---
 src/Products.CMFEditions/Products/CMFEditions/tests/test_ArchivistTool.py
 (revision 98640)
 +++
 src/Products.CMFEditions/Products/CMFEditions/tests/test_ArchivistTool.py
 (working copy)
 @@ -47,7 +47,8 @@
          self.portal.acl_users.userFolderAddUser('reviewer', 'reviewer',
                                                  ['Manager'], '')
          self.portal.invokeFactory('Document', 'doc')
 -        self.portal.invokeFactory('Folder', 'fol')
 +        self.portal.portal_types.getTypeInfo('Large Plone
 Folder').global_allow = True
 +        self.portal.invokeFactory('Large Plone Folder', 'fol')
          self.portal.fol.invokeFactory('Document', 'doc1_inside')
          self.portal.fol.invokeFactory('Document', 'doc2_inside')
          self.portal.fol.invokeFactory('Document', 'doc3_outside')
 }}}
 iow, btree folders don't seem to be compatible with versioning atm.  my
 guess is that perhaps nobody really tried to use this combination before,
 especially when taking into consideration that "large folders" have so far
 been mostly neglected in plone...

 i'll try to have a look into this, even though it's strictly not a related
 problem.  however, if we want to migrate to btree folders, the issue must
 be addressed, of course...

 >  I think it's probably okay for these to be put off and fixed as part of
 the merge, as long as it gets done. ;)

 yes, it needs to get done, of course, but i'm also planning on it... :)

 > The migration looks good...shouldn't we have this get called from an
 upgrade step in plone.app.upgrade though?

 we should — i'll add it to the list...

-- 
Ticket URL: <http://dev.plone.org/plone/ticket/9316#comment:37>
Plone <http://plone.org>
Plone Content Management System


More information about the PLIP-Advisories mailing list