[PLIP-Advisories] Re: [Plone] #8801: Move action icon support into actions, remove CMFActionIcons
plip-advisories at lists.plone.org
plip-advisories at lists.plone.org
Mon Jul 13 07:22:24 UTC 2009
#8801: Move action icon support into actions, remove CMFActionIcons
----------------------------+-----------------------------------------------
Reporter: hannosch | Owner: davisagli
Type: PLIP | Status: assigned
Priority: minor | Milestone: 4.0
Component: Infrastructure | Resolution:
Keywords: |
----------------------------+-----------------------------------------------
Changes (by davisagli):
* status: new => assigned
Old description:
> = Overview =
>
> Since CMF 2.1 (Plone 3.0) action objects have gained an extra attribute
> called icon. This allows you to specify the icons associated with an
> action directly on the action. As a result the CMFActionIcons product has
> become obsolete.
>
> We should remove the CMFActionIcons product and move all our icons to be
> stored on the actions themselves.
>
> = Motivation =
>
> Removing the portal_actionicons tool gets rid of a dependency on a
> package that is no longer necessary.
>
> = Implementation / Deliverables =
>
> * Plone no longer depends on Products.CMFActionIcons
> * Plone accesses actions directly rather than accessing the action icons
> API in order to look up icons.
> * Plone's profile sets appropriate default icons on the relevant
> actions.
> * A migration step copies icon configuration from portal_actionicons to
> the actions themselves, then removes portal_actionicons.
>
> = Risks =
>
> * Add-on products would need to be adjusted to set icon expressions in
> actions.xml rather than actionicons.xml.
> * Add-on products may assume that portal_actionicons is present.
>
> = Progress =
>
> Hanno has already implemented the removal of the tool and setting icons
> on the actions tool on Plone trunk. David has included this in his Plone
> 4 branch, though it could be backed out. The migration has not been
> written yet.
>
> = Participants =
>
> I (David Glick) am willing to do the work required.
New description:
= Overview =
Since CMF 2.1 (Plone 3.0) action objects have gained an extra attribute
called icon. This allows you to specify the icons associated with an
action directly on the action. As a result the CMFActionIcons product has
become obsolete.
We should deprecate the portal_actionicons tool and move all our icons to
be stored on the actions themselves.
= Motivation =
Deprecating the portal_actionicons tool paves the way to getting rid of a
dependency on a package that is no longer necessary.
= Implementation / Deliverables =
* Plone prefers action icons set directly on the action, then falls back
to portal_actionicons. (This is already in place in 3.x)
* Plone's own icons will be switched to be directly on the action,
including any necessary migration from portal_actionicons.
* Use of portal_actionicons will result in a deprecation warning.
= Risks =
I don't think there are any significant risks to the revised proposal.
= Progress =
Hanno has already implemented complete removal of the portal_actionicons
tool on trunk.
= Participants =
I (David Glick) am willing to do the work required.
--
Comment:
Updated the description to reflect modifications that were proposed in
conversation with the FWT.
--
Ticket URL: <http://dev.plone.org/plone/ticket/8801#comment:17>
Plone <http://plone.org>
Plone Content Management System
More information about the PLIP-Advisories
mailing list