[Framework-Team] Re: PLIP 10359 for Plone 4.1 - Convert control panels to use z3c.form
hanno at hannosch.eu
Sun Mar 21 19:21:57 UTC 2010
On Sun, Mar 21, 2010 at 8:15 PM, David Glick <davidglick at groundwire.org> wrote:
> On 3/21/10 7:40 AM, Hanno Schlichting wrote:
>> On Sun, Mar 21, 2010 at 2:26 PM, Martin Aspeli <optilude+lists at gmail.com> wrote:
>>> I suggest we use the dict context (implement getContent() and return a dict)
>>> instead of all those adapters to get/set values as we do presently.
>> Ok. I'll have a look at that.
>> Those adapters only exist, as the context of the form is the plone
>> site root, but the settings come from many different places. Some of
>> the forms redefine self.context, some of them use some property
>> helpers to deal with portal_properties and value conversions. So there
>> needs to be some form of intermediate layer in between, but I don't
>> care what it is.
> -1 on this, which feels like change just for change's sake -- unless
> it's really clear it makes the code more readable.
Is that a -1 on Martin's dict context / getContent() suggestion?
I'd like to have those forms be good examples of using z3c.form, so
I'd like to use whatever is considered to be best practice. The
use-case is having standalone forms which pull their data from a
More information about the Framework-Team