[Framework-Team] PLIP #126 ready for review

Andrew Burkhalter andrewburkhalter at gmail.com
Sat Jan 31 01:22:34 UTC 2009


<snip>

> * Running the tests of plone.app.controlpanel on a vanilla checkout of the
> plip buildout generated one failure for me (Ubuntu/packaged uncustomized
> Python 2.4):
>
> ...
>
>  Set up Products.PloneTestCase.layer.PloneSite in 18.665 seconds.
>  Running:
> .................................................................................................................
>
> Failure in test
> /home/ritz/buildouts/reviewing/plip126-link-redirects/src/plone.app.controlpanel/plone/app/controlpanel/tests/types.txt
> Failed doctest test for types.txt
>  File
> "/home/ritz/buildouts/reviewing/plip126-link-redirects/src/plone.app.controlpanel/plone/app/controlpanel/tests/types.txt",
> line 0
>
> ----------------------------------------------------------------------
> File
> "/home/ritz/buildouts/reviewing/plip126-link-redirects/src/plone.app.controlpanel/plone/app/controlpanel/tests/types.txt",
> line 75, in types.txt
> Failed example:
>   self.browser.contents
> Expected:
>   '...Globally addable...
>   ...Allow comments...
>   ...Visible in searches...
>   ...<input id="redirect_links"...
>   ...type="checkbox"...
>   ...name="redirect_links:boolean"...
>   ...checked="checked">...
>   ...<label for="redirect_links">...
>   ...Redirect links to remote url...'
> Got:
>   '\n  \n\n\n<!DOCTYPE html PUBLIC\n  "-//W3C//DTD XHTML 1.0
> Transitional//EN"\n
>  "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">\n\n\n<html
> xmlns="http://www.w3.org/1999/xhtml" xml:lang="en"\n      lang="en">\n\n
> (truncated by me here)
>
> Guess it's because it expects ...Redirect links to remote url...' but
> it gets ...Redirect immediately to link target...
>


Just for the record, this was broken for a brief time on our branch
due to some jostling around of language, but was resolved in the
following changeset:
http://dev.plone.org/plone/changeset/24272

I hope that lies w/in your "as of 2009-01-16" range (e.g. it was fixed
right after you started your review).  Not sure though.  I'm not
seeing a failure right now at least.

I can look at the CMFPlone failures now.

Andrew




More information about the Framework-Team mailing list