[Framework-Team] PLIP #241 ready for review

[Andreas Zeidler]

On Jan 21, 2009, at 12:37 PM, Martijn Pieters wrote:
> On Sun, Jan 18, 2009 at 01:20, Andreas Zeidler <az at zitc.de> wrote:
>> the review bundle for PLIP 241 (Clean up auto-sort, auto-order  
>> code) is
>> ready for review.  you can get it from
>> https://svn.plone.org/svn/plone/review/plip241-auto-sort-cleanup/
>>
>> review notes are available in the bundle's top-level `README.txt`  
>> file.
>
> On the whole the cleanup looks fine to me.

*phew* :)

> I do wonder about http://dev.plone.org/collective/changeset/79241
> though; Products.Archetypes.OrderedBaseFolder.OrderedBaseFolder does
> the same thing apart from the re-index, so you can remove most of the
> method in ATContentTypes.

yep, i was gonna look into that again during the "revision period",  
i.e. next week.  i wrapped the PLIP up too late and was too tired to  
debug when i noticed the test failure.  so i figured i'd restore the  
method for the time being, hoping the reviewers would come up with  
useful hints... ;)

but seriously, looking at the two quickly i had the impression they  
were doing the same.  obviously there's some subtle different,  
though.  but like i said, i'll debug it a bit next week.

> A next step (not necessarily for this PLIP) would be to move that test
> in CMFPlone mentioned in r79241 to be moved to ATContentTypes, or both
> test and the re-index to be moved to Archetypes, if it is appropriate
> there.

+1


andi

--
zeidler it consulting - http://zitc.de/ - info at zitc.de
friedelstraße 31 - 12047 berlin - telefon +49 30 25563779
pgp key at http://zitc.de/pgp - http://wwwkeys.de.pgp.net/
plone 3.1.7 released! -- http://plone.org/products/plone/

-------------- next part --------------
A non-text attachment was scrubbed...
Name: PGP.sig
Type: application/pgp-signature
Size: 186 bytes
Desc: This is a digitally signed message part
URL: <http://lists.plone.org/pipermail/plone-framework-team/attachments/20090127/83f5d56a/attachment.sig>