[Framework-Team] Re: PLIP #234 Review Revisions

Raphael Ritz raphael.ritz at incf.org
Thu Feb 12 14:10:40 UTC 2009

Martin Aspeli wrote:
> [..]
> FWIW, I think much of Calvin's work could've gone into a 3.2.x release 
> as bug fixes. If he doesn't break tests, and writes a few tests for 
> truly new code, then I think that's probably sufficient in most places.

Personally, I agree with the sentiment that this is mostly
a bug fix in nature.
While I still plan to take a look on Saturday I won't vote
it down for what's being discussed most recently here.


> Having done something similar in the past (but not read Calvin's diff 
> in detail), I suspect most of his changes were simply to stop people 
> making use of portal_url() when they should've used 
> get_navigation_root(). There may be cases when we could add a "defect" 
> type test to show that the navigation root didn't work before, but now 
> does, but let's not create too much work for what is, in many cases, 
> more about analysing a problem and applying a few surgical fixes, than 
> writing a ton of new code.
> Martin

More information about the Framework-Team mailing list