[Framework-Team] PLIP #234 Review Revisions
az at zitc.de
Thu Feb 12 12:05:34 UTC 2009
On Feb 10, 2009, at 6:55 AM, Calvin Hendryx-Parker wrote:
> Hi Team,
> I just committed my revisions based on the initial review of PLIP 234.
> I believe I have addressed all of the concerns brought up by the
unfortunately i won't have enough time left to look at your changes
(leaving for vacation tomorrow). tom will do the extra round of
reviewing, though, and i guess one reviewer should be enough in this
case (or else maybe another team member wants to take a second
anyway, just one more comment...
> [...] and found that I had already written tests for the viewlet
> code changes that didn't get considered in your diffs, but those
> tests still pass.
> Those tests are found here:
they did (as a new file). i did notice that test (which is why i
added "almost" in "almost none of the changes are actually
tested" ;)), but found that one was far from enough. anyway, tom will
make sure there are enough now... ;)
zeidler it consulting - http://zitc.de/ - info at zitc.de
friedelstraße 31 - 12047 berlin - telefon +49 30 25563779
pgp key at http://zitc.de/pgp - http://wwwkeys.de.pgp.net/
plone 3.2.1 released! -- http://plone.org/products/plone/
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 186 bytes
Desc: This is a digitally signed message part
More information about the Framework-Team