[Framework-Team] PLIP #234 Review Revisions

Tom Lazar lists at tomster.org
Wed Feb 11 12:24:01 UTC 2009


thanks, calvin!

i'll take a look at it ASAP, which probably will mean saturday,  
though...

also thanks for the changeset url, that kind of stuff is really  
helpful for reviewers (*hint* *hint* to other list members ;-)

cheers,

tom

On 10.02.2009, at 06:55, Calvin Hendryx-Parker wrote:

> Hi Team,
>
> I just committed my revisions based on the initial review of PLIP  
> 234.  I also have included some more docs about the PLIP here:
>
> http://dev.plone.org/plone/browser/review/plip234-inavigationroot-fixes/PLIP_234_README.txt
>
> I believe I have addressed all of the concerns brought up by the  
> reviewers.  There is a summary of these changes in the  
> PLIP_234_README.txt file.  I added tests for some new changes to the  
> calendar tool and found that I had already written tests for the  
> viewlet code changes that didn't get considered in your diffs, but  
> those tests still pass.
>
> Those tests are found here:
> http://dev.plone.org/plone/changeset/23315
>
> Please let me know if you have any questions at all.
>
> Cheers,
> Calvin
>
> -- 
> S i x  F e e t  U p ,  I n c .   http://www.sixfeetup.com
> Phone: +1 (317) 861-5948 x602
> calvin at sixfeetup.com
> ANNOUNCING the first Plone Immersive Training Experience | Sept.  
> 10-11-12, 2009
> http://www.sixfeetup.com/immerse
>
>
> _______________________________________________
> Framework-Team mailing list
> Framework-Team at lists.plone.org
> http://lists.plone.org/mailman/listinfo/framework-team
>





More information about the Framework-Team mailing list