[Framework-Team] Re: Merged PLIPs 184, 200, 202, 203 and 204

[George Lee]

Martin Aspeli <optilude at ...> writes:

> >> It probably also makes sense to extend my test_configuration.py test 
> >> case with some more examples that cover George's new GS syntax. This is 
> >> overlapping with, but different to George's test_exportimport.xml (his 
> >> tests the handles directly, mine is an integration test that actually 
> >> loads a profile and then export it again). George, would you be up for 
> >> that? It should be pretty simple.


Hi Martin,

I looked over the code -- some comments and questions:

(1) Why is the line

  <five:registerPackage package="." initialize=".initialize" />

added -- isn't this only to allow a package to be installable as a Zope2
product? Is this needed for plone.app.portlets?

(2) The import for blacklisting allows specifying location, but not the import
for assignments. Can this be broadened?

(3) The export for blacklisting only exports blacklisting at the site root. This
means round-trip import/export wouldn't work. I can imagine it's inefficient to
crawl the whole site to look for blacklisting, but is there a way to do it?

(4) The new test_configuration.py loads ZCML to register a new profile. It's
fairly non-invasive (since the actual importing of the profile happens within
the tests, so is undone after the tests), but the ZCML remains loaded afterward
instead of being torn down. Is there a way to unregister the profile?

(5) I made a small change to the docstring of _purgePortlets to make it accurate:

(http://dev.plone.org/plone/changeset/19635/plone.app.portlets/trunk/plone/app/portlets/exportimport/portlets.py)

(6) I haven't updated the new test_configuration.py tests because the import
profile portlets.xml is already pretty packed. I could create a second profile
which would make me feel more comfortable, but my worry about adding new XML
into the existing test portlets.xml is that the test is testing multiple
features which are entangled with each other in the same file to import, the
same test setup, etc. Do you think it makes sense to create a second testing
profile rather than intermix with the existing one?


Peace,
George