[Framework-Team] Re: wicked - lxml dependency?

[whit]

Rocky wrote:
> Hanno Schlichting wrote:
>   
>> Is lxml a real dependency for the functionality we use in Plone or is it
>> optional or only required to run the tests?
>>     
>
> If lxml is not required (but can be used) by wicked then the tests
> should reflect the same thing imho.  The tests should conditionally
> test lxml only if available.
>
> If the tests fail because lxml doesn't exist, then wicked itself
> shouldn't work when deployed either without lxml.
>
> - Rocky
>
>
> _______________________________________________
> Framework-Team mailing list
> Framework-Team at lists.plone.org
> http://lists.plone.org/mailman/listinfo/framework-team
>
>   
they error, not fail(which is different). lxml is a tool for testing in 
this case.  the tests are old style unit tests and someday they will get 
rewritten in more modern forms.

the use lxml is primarily to make test output understandable by 
stripping out the whitespace created by TAL while testing the rendering 
of links (20 some tests, essentially AT/plone integration tests.  This 
suite is run twice, one to test basic setup, a second time to test the 
specialize plone registrations).  The dependency is on libxslt2-py or 
lxml.  wicked in no way uses lxml in it's actua function.

we could turn these tests off for systems without libxslt or lxml and 
emit a warning. if someone has a whitespace normalizing routine that is 
standard library friendly that would work too.

-w

-- 

------ d. whit morriss ------
- senior engineer, opencore -
- http://www.openplans.org  -
- m: 415-710-8975           -

"If you don't know where you are,   
 you don't know anything at all"                                             

Dr. Edgar Spencer, Ph.D., 1995

-------------- next part --------------
A non-text attachment was scrubbed...
Name: whit.vcf
Type: text/x-vcard
Size: 291 bytes
Desc: not available
URL: <http://lists.plone.org/pipermail/plone-framework-team/attachments/20070213/5ea7c0ea/attachment.vcf>